You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by David Chen <dc...@linkedin.com> on 2014/07/11 03:21:04 UTC
Re: Review Request 23153: HIVE-5976: Decouple input formats from STORED as
keywords.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23153/
-----------------------------------------------------------
(Updated July 11, 2014, 1:20 a.m.)
Review request for hive.
Summary (updated)
-----------------
HIVE-5976: Decouple input formats from STORED as keywords.
Bugs: HIVE-5976
https://issues.apache.org/jira/browse/HIVE-5976
Repository: hive-git
Description (updated)
-------
HIVE-5976: Decouple input formats from STORED as keywords.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8bff2a96fbfc572d86e6a6cdbc2a74ff4f5b0609
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java ec24531117203a5c75c62d0e5b54d5a43d37fa79
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextSerDe.java PRE-CREATION
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextStorageFormatDescriptor.java PRE-CREATION
itests/custom-serde/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/AbstractStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java 41310661ced0616f6bee27af2b1195127e5230e8
ql/src/java/org/apache/hadoop/hive/ql/io/ORCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/ParquetFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/RCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/SequenceFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatFactory.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/TextFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 60d54b6a04e1a9601342b0159387114f7b666338
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 640b6b319ce84a875cc78cb8b29fa6bbc1067fc5
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 412a046488eaea42a6416c7cbd514715d37e249f
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 5ac64527497d3d047d6c7bffd64c4201a66a2a04
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 9c001c1495b423c19f3fa710c74f1bb1e24a08f4
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 0af25360ee6f3088c764f0c4d812f30d1eeb91d6
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c42923f716afb89ac6c60fb386fb91c1c94413dd
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java PRE-CREATION
ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java PRE-CREATION
ql/src/test/queries/clientpositive/storage_format_descriptor.q PRE-CREATION
ql/src/test/results/clientnegative/fileformat_bad_class.q.out ab1e9357c0a7d4e21816290fbf7ed99396932b92
ql/src/test/results/clientnegative/genericFileFormat.q.out 9613df95c8fc977c0ad1f717afa2db3870dfd904
ql/src/test/results/clientpositive/create_union_table.q.out dc994f161a0a4372bfe009017f45ade56f06ae6e
ql/src/test/results/clientpositive/ctas.q.out 5af90d03b72d42c30c4d31ce6b28bfd5493470ac
ql/src/test/results/clientpositive/ctas_colname.q.out 20259a7662ec2e4b3157f90ab1c3913b57798d65
ql/src/test/results/clientpositive/ctas_uses_database_location.q.out a2c8c4a874e6ba4e926f47b354bf9e5dd8b0569e
ql/src/test/results/clientpositive/groupby_duplicate_key.q.out e37b2d4ea286971dd2e351463e98e92c64c5d7d5
ql/src/test/results/clientpositive/input15.q.out a9575ddb675961fdc3fb73f2774c2fa8f2c08cd9
ql/src/test/results/clientpositive/inputddl1.q.out 17bdd7b220166b077f6368b1d51b928d7d1d638a
ql/src/test/results/clientpositive/inputddl2.q.out f53b0b7039bfbbdf87a09a16d96049739b069ee8
ql/src/test/results/clientpositive/inputddl3.q.out 6682b09e33d673aac02e50a6d260797d66ea1676
ql/src/test/results/clientpositive/merge3.q.out 41b7972381a69f8066c5ca52dcc8335c2c9cd05d
ql/src/test/results/clientpositive/nonmr_fetch.q.out 5a13e841ec53e7a59ad34595ef95ee6f5480992c
ql/src/test/results/clientpositive/nullformat.q.out 07dae64f410cc0e847e5ded1e00198d47c65e497
ql/src/test/results/clientpositive/nullformatCTAS.q.out c76c30bc0b0431b31424ea31b934241674da2f83
ql/src/test/results/clientpositive/parallel_orderby.q.out 39582a83a553f7b769695797afcdf6866d8bbdef
ql/src/test/results/clientpositive/skewjoin_noskew.q.out 44e920e5c1fde042c6c789ff098eb42313beefcd
ql/src/test/results/clientpositive/smb_mapjoin9.q.out f0ab703eeca399e82d891b9c6b9ac6581c1b872a
ql/src/test/results/clientpositive/storage_format_descriptor.q.out PRE-CREATION
ql/src/test/results/clientpositive/temp_table.q.out fbb674f93070cbeca8755736515ab6e440412649
ql/src/test/results/clientpositive/tez/ctas.q.out 6b4c69019d45976bd0ccb705331948cd240e5750
ql/src/test/results/clientpositive/tez/tez_dml.q.out 583f35b79d1470ee75666a17b08ee6961c6d13f8
ql/src/test/results/clientpositive/union25.q.out b5aff959e9acd15efb51f476673b71811a8019c8
ql/src/test/results/clientpositive/union_top_level.q.out a01571c82a930ed54448b2c39be54baa99310dd6
Diff: https://reviews.apache.org/r/23153/diff/
Testing
-------
Thanks,
David Chen
Re: Review Request 23153: HIVE-5976: Decouple input formats from STORED as
keywords.
Posted by David Chen <dc...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23153/
-----------------------------------------------------------
(Updated July 14, 2014, 7:22 a.m.)
Review request for hive.
Changes
-------
Rebase on trunk.
Bugs: HIVE-5976
https://issues.apache.org/jira/browse/HIVE-5976
Repository: hive-git
Description
-------
HIVE-5976: Decouple input formats from STORED as keywords.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b6448b721681beeabed85b67a6b3e5e1c57350e7
conf/hive-default.xml.template 0d38a03d6e4999f2d43acf67a4c0c23d0823a2cc
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java ec24531117203a5c75c62d0e5b54d5a43d37fa79
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextSerDe.java PRE-CREATION
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextStorageFormatDescriptor.java PRE-CREATION
itests/custom-serde/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/AbstractStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java 41310661ced0616f6bee27af2b1195127e5230e8
ql/src/java/org/apache/hadoop/hive/ql/io/ORCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/ParquetFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/RCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/SequenceFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatFactory.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/TextFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 7c73f96d1c87ab2d9fbff9f5906f46f90d036838
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 355d0721e80e9d9d0a5958828acc866815b1d963
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0077437a3f3fe59b0ca08b7da52643d6bc079bfd
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 5f53677dbe8ef94d65652bba378b2a6f20d6457b
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 9c001c1495b423c19f3fa710c74f1bb1e24a08f4
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 0af25360ee6f3088c764f0c4d812f30d1eeb91d6
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c42923f716afb89ac6c60fb386fb91c1c94413dd
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java PRE-CREATION
ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java PRE-CREATION
ql/src/test/queries/clientpositive/storage_format_descriptor.q PRE-CREATION
ql/src/test/results/clientnegative/fileformat_bad_class.q.out ab1e9357c0a7d4e21816290fbf7ed99396932b92
ql/src/test/results/clientnegative/genericFileFormat.q.out 9613df95c8fc977c0ad1f717afa2db3870dfd904
ql/src/test/results/clientpositive/create_union_table.q.out dc994f161a0a4372bfe009017f45ade56f06ae6e
ql/src/test/results/clientpositive/ctas.q.out 5af90d03b72d42c30c4d31ce6b28bfd5493470ac
ql/src/test/results/clientpositive/ctas_colname.q.out 20259a7662ec2e4b3157f90ab1c3913b57798d65
ql/src/test/results/clientpositive/ctas_uses_database_location.q.out a2c8c4a874e6ba4e926f47b354bf9e5dd8b0569e
ql/src/test/results/clientpositive/groupby_duplicate_key.q.out e37b2d4ea286971dd2e351463e98e92c64c5d7d5
ql/src/test/results/clientpositive/input15.q.out a9575ddb675961fdc3fb73f2774c2fa8f2c08cd9
ql/src/test/results/clientpositive/inputddl1.q.out 17bdd7b220166b077f6368b1d51b928d7d1d638a
ql/src/test/results/clientpositive/inputddl2.q.out f53b0b7039bfbbdf87a09a16d96049739b069ee8
ql/src/test/results/clientpositive/inputddl3.q.out 6682b09e33d673aac02e50a6d260797d66ea1676
ql/src/test/results/clientpositive/merge3.q.out 41b7972381a69f8066c5ca52dcc8335c2c9cd05d
ql/src/test/results/clientpositive/nonmr_fetch.q.out 5a13e841ec53e7a59ad34595ef95ee6f5480992c
ql/src/test/results/clientpositive/nullformat.q.out 07dae64f410cc0e847e5ded1e00198d47c65e497
ql/src/test/results/clientpositive/nullformatCTAS.q.out c76c30bc0b0431b31424ea31b934241674da2f83
ql/src/test/results/clientpositive/parallel_orderby.q.out 39582a83a553f7b769695797afcdf6866d8bbdef
ql/src/test/results/clientpositive/skewjoin_noskew.q.out 44e920e5c1fde042c6c789ff098eb42313beefcd
ql/src/test/results/clientpositive/smb_mapjoin9.q.out f0ab703eeca399e82d891b9c6b9ac6581c1b872a
ql/src/test/results/clientpositive/storage_format_descriptor.q.out PRE-CREATION
ql/src/test/results/clientpositive/temp_table.q.out fbb674f93070cbeca8755736515ab6e440412649
ql/src/test/results/clientpositive/tez/ctas.q.out 6b4c69019d45976bd0ccb705331948cd240e5750
ql/src/test/results/clientpositive/tez/tez_dml.q.out 583f35b79d1470ee75666a17b08ee6961c6d13f8
ql/src/test/results/clientpositive/union25.q.out b5aff959e9acd15efb51f476673b71811a8019c8
ql/src/test/results/clientpositive/union_top_level.q.out a01571c82a930ed54448b2c39be54baa99310dd6
Diff: https://reviews.apache.org/r/23153/diff/
Testing
-------
Thanks,
David Chen
Re: Review Request 23153: HIVE-5976: Decouple input formats from STORED as
keywords.
Posted by David Chen <dc...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23153/
-----------------------------------------------------------
(Updated July 12, 2014, 3:44 a.m.)
Review request for hive.
Changes
-------
Update test output and rebase on trunk.
Bugs: HIVE-5976
https://issues.apache.org/jira/browse/HIVE-5976
Repository: hive-git
Description
-------
HIVE-5976: Decouple input formats from STORED as keywords.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8bff2a96fbfc572d86e6a6cdbc2a74ff4f5b0609
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java ec24531117203a5c75c62d0e5b54d5a43d37fa79
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextSerDe.java PRE-CREATION
itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomTextStorageFormatDescriptor.java PRE-CREATION
itests/custom-serde/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/AbstractStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java 41310661ced0616f6bee27af2b1195127e5230e8
ql/src/java/org/apache/hadoop/hive/ql/io/ORCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/ParquetFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/RCFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/SequenceFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatFactory.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/TextFileStorageFormatDescriptor.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 7c73f96d1c87ab2d9fbff9f5906f46f90d036838
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 640b6b319ce84a875cc78cb8b29fa6bbc1067fc5
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 412a046488eaea42a6416c7cbd514715d37e249f
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 23c9d5c90027afbe17806320bbe0694802fc9d5e
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 9c001c1495b423c19f3fa710c74f1bb1e24a08f4
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 0af25360ee6f3088c764f0c4d812f30d1eeb91d6
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c42923f716afb89ac6c60fb386fb91c1c94413dd
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java PRE-CREATION
ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java PRE-CREATION
ql/src/test/queries/clientpositive/storage_format_descriptor.q PRE-CREATION
ql/src/test/results/clientnegative/fileformat_bad_class.q.out ab1e9357c0a7d4e21816290fbf7ed99396932b92
ql/src/test/results/clientnegative/genericFileFormat.q.out 9613df95c8fc977c0ad1f717afa2db3870dfd904
ql/src/test/results/clientpositive/create_union_table.q.out dc994f161a0a4372bfe009017f45ade56f06ae6e
ql/src/test/results/clientpositive/ctas.q.out 5af90d03b72d42c30c4d31ce6b28bfd5493470ac
ql/src/test/results/clientpositive/ctas_colname.q.out 20259a7662ec2e4b3157f90ab1c3913b57798d65
ql/src/test/results/clientpositive/ctas_uses_database_location.q.out a2c8c4a874e6ba4e926f47b354bf9e5dd8b0569e
ql/src/test/results/clientpositive/groupby_duplicate_key.q.out e37b2d4ea286971dd2e351463e98e92c64c5d7d5
ql/src/test/results/clientpositive/input15.q.out a9575ddb675961fdc3fb73f2774c2fa8f2c08cd9
ql/src/test/results/clientpositive/inputddl1.q.out 17bdd7b220166b077f6368b1d51b928d7d1d638a
ql/src/test/results/clientpositive/inputddl2.q.out f53b0b7039bfbbdf87a09a16d96049739b069ee8
ql/src/test/results/clientpositive/inputddl3.q.out 6682b09e33d673aac02e50a6d260797d66ea1676
ql/src/test/results/clientpositive/merge3.q.out 41b7972381a69f8066c5ca52dcc8335c2c9cd05d
ql/src/test/results/clientpositive/nonmr_fetch.q.out 5a13e841ec53e7a59ad34595ef95ee6f5480992c
ql/src/test/results/clientpositive/nullformat.q.out 07dae64f410cc0e847e5ded1e00198d47c65e497
ql/src/test/results/clientpositive/nullformatCTAS.q.out c76c30bc0b0431b31424ea31b934241674da2f83
ql/src/test/results/clientpositive/parallel_orderby.q.out 39582a83a553f7b769695797afcdf6866d8bbdef
ql/src/test/results/clientpositive/skewjoin_noskew.q.out 44e920e5c1fde042c6c789ff098eb42313beefcd
ql/src/test/results/clientpositive/smb_mapjoin9.q.out f0ab703eeca399e82d891b9c6b9ac6581c1b872a
ql/src/test/results/clientpositive/storage_format_descriptor.q.out PRE-CREATION
ql/src/test/results/clientpositive/temp_table.q.out fbb674f93070cbeca8755736515ab6e440412649
ql/src/test/results/clientpositive/tez/ctas.q.out 6b4c69019d45976bd0ccb705331948cd240e5750
ql/src/test/results/clientpositive/tez/tez_dml.q.out 583f35b79d1470ee75666a17b08ee6961c6d13f8
ql/src/test/results/clientpositive/union25.q.out b5aff959e9acd15efb51f476673b71811a8019c8
ql/src/test/results/clientpositive/union_top_level.q.out a01571c82a930ed54448b2c39be54baa99310dd6
Diff: https://reviews.apache.org/r/23153/diff/
Testing
-------
Thanks,
David Chen