You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by Ju...@empolis.com on 2008/12/15 13:23:24 UTC

RE: [jira] Updated: (ODE-429) Patch to make Saxon and Jaxen optional for XPath 1.0 processing

Hi,

Sorry. I know, I'm bothering, but this issue is quite important for us.

What do you think about this patch? Is there anything I can improve? 
There was no further feedback to my last version of the patch,
so I assumed everything is OK with it.

However, if you are not willing to include this into your codebase, please 
tell me. I will try something similar in our own codebase then.

Anyway, are there any news about a (beta) release date for a trunk release (2.0)? 
I suppose the "at the end of year" time frame mentioned in earlier mails here
will be a bit tight? (-;

Cheers,
Juergen

> -----Original Message-----
> From: Jürgen Schumacher (JIRA) [mailto:jira@apache.org]
> Sent: Tuesday, November 25, 2008 11:14 AM
> To: dev@ode.apache.org
> Subject: [jira] Updated: (ODE-429) Patch to make Saxon and Jaxen
> optional for XPath 1.0 processing
> 
> 
>      [ https://issues.apache.org/jira/browse/ODE-
> 429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> 
> Jürgen Schumacher updated ODE-429:
> ----------------------------------
> 
>     Attachment: ode-xpath1-jaxp-2008-11-25.patch
> 
> Thanks for your feedback, Matthieu.
> 
> I was catching Throwable, because in my tests the creation of the
> expression compilers threw NoClassDefFoundError instead of
> ClassNotFoundException when Saxon or Jaxen were not available. I do not
> know if this is because we are inside Equinox and the classloaders
> behave differently. Anyway, I have created this new patch that catches
> Exception and NoClassDefFoundError seperatly. I definitely need to
> catch this error here to make the patch work.
> It's again a complete patch against the current trunk (still the same
> rev as yesterday, it seems), so the older attachments are obsolete.
> 
> Cheers,
> Juergen.
> 
> > Patch to make Saxon and Jaxen optional for XPath 1.0 processing
> > ---------------------------------------------------------------
> >
> >                 Key: ODE-429
> >                 URL: https://issues.apache.org/jira/browse/ODE-429
> >             Project: ODE
> >          Issue Type: Improvement
> >          Components: BPEL Compilation/Parsing, BPEL Runtime
> >    Affects Versions: 2.0
> >            Reporter: Jürgen Schumacher
> >             Fix For: 2.0
> >
> >         Attachments: ode-xpath1-jaxp-2008-11-24.patch, ode-xpath1-
> jaxp-2008-11-25.patch, ode-xpath1-jaxp.patch
> >
> >
> > See
> http://ode.markmail.org/search/?q=saxon+jaxen#query:saxon%20jaxen+page:
> 1+mid:3sramehxzsfceg76+state:results
> > This patch adds classes for XPath 1.0 compilation and evaluation
> based only on JAXP interfaces, independent on any specific JAXP
> implementation. It's selected as a fallback in the BPELCompilers if
> instantiating the existing XPath-1.0-implementation based on Jaxen (and
> Saxon for doXslTransform) fails. This enables us to remove Jaxen and
> Saxon from the classpath which are not accepted by the Eclipse
> foundation because of legal issues (code provenance problems...). So
> the default behaviour of ODE should be the same as without these
> changes.
> 
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.


RE: [jira] Updated: (ODE-429) Patch to make Saxon and Jaxen optional for XPath 1.0 processing

Posted by Ju...@empolis.com.
Hi,

> We are certainly willing to include it. The only issue here is time and
> I'm sorry that it's taken so long, my bad.

Thank you for this information, that's really good for us. 
No offense intended - I was just wondering because you usually react very fast 
on these lists. So I was a bit confused about the silence.

> > Anyway, are there any news about a (beta) release date for a trunk release (2.0)?
> > [...]
> Maybe Chistmas :)

That would really be a nice present (-: 

Cheers,
Juergen

Re: [jira] Updated: (ODE-429) Patch to make Saxon and Jaxen optional for XPath 1.0 processing

Posted by Matthieu Riou <ma...@gmail.com>.
On Mon, Dec 15, 2008 at 4:23 AM, <Ju...@empolis.com> wrote:

> Hi,
>
> Sorry. I know, I'm bothering, but this issue is quite important for us.
>
> What do you think about this patch? Is there anything I can improve?
> There was no further feedback to my last version of the patch,
> so I assumed everything is OK with it.
>

Sorry for the delay, the patch is big and I don't have much time. But I'll
review it today and apply it if there are no major issues.


>
> However, if you are not willing to include this into your codebase, please
> tell me. I will try something similar in our own codebase then.


We are certainly willing to include it. The only issue here is time and I'm
sorry that it's taken so long, my bad.


>
>
> Anyway, are there any news about a (beta) release date for a trunk release
> (2.0)?
> I suppose the "at the end of year" time frame mentioned in earlier mails
> here
> will be a bit tight? (-;


Maybe Chistmas :)

Matthieu


>
>
> Cheers,
> Juergen
>
> > -----Original Message-----
> > From: Jürgen Schumacher (JIRA) [mailto:jira@apache.org]
> > Sent: Tuesday, November 25, 2008 11:14 AM
> > To: dev@ode.apache.org
> > Subject: [jira] Updated: (ODE-429) Patch to make Saxon and Jaxen
> > optional for XPath 1.0 processing
> >
> >
> >      [ https://issues.apache.org/jira/browse/ODE-
> > 429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> >
> > Jürgen Schumacher updated ODE-429:
> > ----------------------------------
> >
> >     Attachment: ode-xpath1-jaxp-2008-11-25.patch
> >
> > Thanks for your feedback, Matthieu.
> >
> > I was catching Throwable, because in my tests the creation of the
> > expression compilers threw NoClassDefFoundError instead of
> > ClassNotFoundException when Saxon or Jaxen were not available. I do not
> > know if this is because we are inside Equinox and the classloaders
> > behave differently. Anyway, I have created this new patch that catches
> > Exception and NoClassDefFoundError seperatly. I definitely need to
> > catch this error here to make the patch work.
> > It's again a complete patch against the current trunk (still the same
> > rev as yesterday, it seems), so the older attachments are obsolete.
> >
> > Cheers,
> > Juergen.
> >
> > > Patch to make Saxon and Jaxen optional for XPath 1.0 processing
> > > ---------------------------------------------------------------
> > >
> > >                 Key: ODE-429
> > >                 URL: https://issues.apache.org/jira/browse/ODE-429
> > >             Project: ODE
> > >          Issue Type: Improvement
> > >          Components: BPEL Compilation/Parsing, BPEL Runtime
> > >    Affects Versions: 2.0
> > >            Reporter: Jürgen Schumacher
> > >             Fix For: 2.0
> > >
> > >         Attachments: ode-xpath1-jaxp-2008-11-24.patch, ode-xpath1-
> > jaxp-2008-11-25.patch, ode-xpath1-jaxp.patch
> > >
> > >
> > > See
> > http://ode.markmail.org/search/?q=saxon+jaxen#query:saxon%20jaxen+page:
> > 1+mid:3sramehxzsfceg76+state:results
> > > This patch adds classes for XPath 1.0 compilation and evaluation
> > based only on JAXP interfaces, independent on any specific JAXP
> > implementation. It's selected as a fallback in the BPELCompilers if
> > instantiating the existing XPath-1.0-implementation based on Jaxen (and
> > Saxon for doXslTransform) fails. This enables us to remove Jaxen and
> > Saxon from the classpath which are not accepted by the Eclipse
> > foundation because of legal issues (code provenance problems...). So
> > the default behaviour of ODE should be the same as without these
> > changes.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
>
>