[GitHub] [kyuubi] cxzl25 commented on a diff in pull request #4389: [KYUUBI #3951][FOLLOWUP] Audit the rest request params

["cxzl25 (via GitHub)" <gi...@apache.org>]

cxzl25 commented on code in PR #4389:
URL: https://github.com/apache/kyuubi/pull/4389#discussion_r1112509354


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/http/authentication/AuthenticationAuditLogger.scala:
##########
@@ -35,6 +35,7 @@ object AuthenticationAuditLogger extends Logging {
     sb.append(s"proxyIp=${HTTP_PROXY_HEADER_CLIENT_IP_ADDRESS.get()}").append("\t")
     sb.append(s"method=${request.getMethod}").append("\t")
     sb.append(s"uri=${request.getRequestURI}").append("\t")
+    Option(request.getQueryString).foreach(params => sb.append(s"params=$params").append("\t"))

Review Comment:
   If `params` has no parameters, can we also output `params=` to ensure the same format?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org