[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull request #529: Add hadoop table catalog (WIP)

[GitBox <gi...@apache.org>]

chenjunjiedada commented on a change in pull request #529: Add hadoop table catalog (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/529#discussion_r334216827
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java
 ##########
 @@ -20,27 +20,30 @@
 package org.apache.iceberg.hadoop;
 
 import com.google.common.base.Preconditions;
-import org.apache.iceberg.*;
-import org.apache.iceberg.catalog.TableIdentifier;
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Map;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.Path;
-
+import org.apache.iceberg.BaseMetastoreCatalog;
+import org.apache.iceberg.PartitionSpec;
+import org.apache.iceberg.Schema;
+import org.apache.iceberg.TableMetadata;
+import org.apache.iceberg.TableOperations;
+import org.apache.iceberg.catalog.TableIdentifier;
 import org.apache.iceberg.exceptions.AlreadyExistsException;
 import org.apache.iceberg.exceptions.RuntimeIOException;
 
-import java.io.Closeable;
-import java.io.IOException;
-import java.util.Map;
 
 public class HadoopCatalog extends BaseMetastoreCatalog implements Closeable {
-  private final String ICEBERG_HADOOP_WAREHOUSE_BASE = "iceberg/warehouse";
-  private final org.apache.hadoop.conf.Configuration conf;
+  private static final String ICEBERG_HADOOP_WAREHOUSE_BASE = "iceberg/warehouse";
 
 Review comment:
   Agreed, that can allow more scenarios. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org