[GitHub] mkiiskila commented on a change in pull request #255: Documented Console 1.1 Improvements.

[gi...@git.apache.org]

mkiiskila commented on a change in pull request #255: Documented Console 1.1 Improvements.
URL: https://github.com/apache/mynewt-site/pull/255#discussion_r127763065
 
 

 ##########
 File path: docs/os/modules/console/console_blocking_mode.md
 ##########
 @@ -4,9 +4,7 @@
 void console_blocking_mode(void)
 ```
 
-Calls the `console_blocking_tx` function to flush the buffered console output (transmit) queue. 
-The function `OS_ENTER_CRITICAL()` is called to disable interrupts and `OS_EXIT_CRITICAL()` 
-is called to enable interrupts back again once the buffer is flushed.
+Sets the transmit mode to blocking. The function flushes the buffered console output.  The function `OS_ENTER_CRITICAL()` is called to disable interrupts and `OS_EXIT_CRITICAL()` is called to enable interrupts back again once the buffer is flushed.
 
 Review comment:
   User should have interrupts disabled when calling this, and should not enable them after the call. UART drivers do not adjust their interrupt delivery settings when console is in 'blocking TX mode', so system behaviour would be undefined/undeterministic, should the user re-enable interrupts.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services