You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2012/06/26 02:07:44 UTC

[jira] [Created] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Jean-Daniel Cryans created HBASE-6268:
-----------------------------------------

             Summary: Can't enable a table on a 0.94 cluster from a 0.92 client
                 Key: HBASE-6268
                 URL: https://issues.apache.org/jira/browse/HBASE-6268
             Project: HBase
          Issue Type: Bug
            Reporter: Jean-Daniel Cryans
             Fix For: 0.92.2


In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:

bq. return getTableState(zkw, tableName) == null;

In 0.94 we do:

bq. return getTableState(zkw, tableName) == TableState.ENABLED;

So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446587#comment-13446587 ] 

Lars Hofhansl commented on HBASE-6268:
--------------------------------------

I'll commit that to 0.94.
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt, 6268-94.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445755#comment-13445755 ] 

Hudson commented on HBASE-6268:
-------------------------------

Integrated in HBase-0.92-security #129 (See [https://builds.apache.org/job/HBase-0.92-security/129/])
    HBASE-6268 Can't enable a table on a 0.94 cluster from a 0.92 client (Revision 1379292)

     Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKTable.java

                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401948#comment-13401948 ] 

Lars Hofhansl commented on HBASE-6268:
--------------------------------------

Sigh... It seems we cannot easily fix this 0.94.1, since we'd have to roll back a bigger change. Is 0.92.2 good enough, though?
The 0.92 fix is obviously trivial just check for TableState.ENABLED or null.

                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.92.2
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-6268:
---------------------------------

    Attachment: 6268-94.txt

0.94 patch.
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt, 6268-94.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446618#comment-13446618 ] 

Hudson commented on HBASE-6268:
-------------------------------

Integrated in HBase-0.94 #446 (See [https://builds.apache.org/job/HBase-0.94/446/])
    HBASE-6268 Can't enable a table on a 0.94 cluster from a 0.92 client (Revision 1379688)

     Result = FAILURE
larsh : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKTable.java

                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2, 0.94.2
>
>         Attachments: 6268-92.txt, 6268-94.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-6268.
--------------------------

      Resolution: Fixed
        Assignee: Ted Yu
    Hadoop Flags: Reviewed

Committed to 0.92.0
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402449#comment-13402449 ] 

Jean-Daniel Cryans commented on HBASE-6268:
-------------------------------------------

This is why I'm not a big fan of backports that are not simple-ish fixes...

So to me the most important would be to fix the 0.92 side as usually the infrastructure in place will rely on the older version first. In our case we started the migration of our clusters to 0.94 starting with the less important ones so our tools are still relying on 0.92
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.92.2
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446445#comment-13446445 ] 

Ted Yu commented on HBASE-6268:
-------------------------------

I think Gregory's post makes sense.

I will wait for further validation result against 0.92.2 RC1 and watch out the discussion thread.
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448261#comment-13448261 ] 

Hudson commented on HBASE-6268:
-------------------------------

Integrated in HBase-0.94-security #51 (See [https://builds.apache.org/job/HBase-0.94-security/51/])
    HBASE-6268 Can't enable a table on a 0.94 cluster from a 0.92 client (Revision 1379688)

     Result = FAILURE
larsh : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKTable.java

                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2, 0.94.2
>
>         Attachments: 6268-92.txt, 6268-94.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446596#comment-13446596 ] 

stack commented on HBASE-6268:
------------------------------

+1 on patch for 0.94
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt, 6268-94.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445685#comment-13445685 ] 

Lars Hofhansl commented on HBASE-6268:
--------------------------------------

+1 on patch.
I apologize to not have caught this in 0.94.0 (HBASE-5206).

                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-6268:
--------------------------

    Attachment: 6268-92.txt

Patch as suggested by Lars.
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448338#comment-13448338 ] 

Hudson commented on HBASE-6268:
-------------------------------

Integrated in HBase-0.94-security-on-Hadoop-23 #7 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/7/])
    HBASE-6268 Can't enable a table on a 0.94 cluster from a 0.92 client (Revision 1379688)

     Result = FAILURE
larsh : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKTable.java

                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2, 0.94.2
>
>         Attachments: 6268-92.txt, 6268-94.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445677#comment-13445677 ] 

stack commented on HBASE-6268:
------------------------------

Patch looks like it covers both cases +1
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445747#comment-13445747 ] 

Hudson commented on HBASE-6268:
-------------------------------

Integrated in HBase-0.92 #549 (See [https://builds.apache.org/job/HBase-0.92/549/])
    HBASE-6268 Can't enable a table on a 0.94 cluster from a 0.92 client (Revision 1379292)

     Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKTable.java

                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446242#comment-13446242 ] 

Jonathan Hsieh commented on HBASE-6268:
---------------------------------------

I'm a bit concerned about this -- i think there are people using 0.92.1 and those clients should work againt the newer 0.94's (which has fewer users since is newer).   We'll start a discussion on the dev list.
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401156#comment-13401156 ] 

ramkrishna.s.vasudevan commented on HBASE-6268:
-----------------------------------------------

https://issues.apache.org/jira/browse/HBASE-5206 caused this.  Infact in 0.90 HBASE-5904 has been raised to back out HBASE-5155.
So the same problem is happening here. :(.
Do we need to back out here also?
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.92.2
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-6268:
---------------------------------

    Fix Version/s: 0.94.2

Committed 0.94 patch as well.
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2, 0.94.2
>
>         Attachments: 6268-92.txt, 6268-94.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446442#comment-13446442 ] 

Gregory Chanan commented on HBASE-6268:
---------------------------------------

Brought up on dev list under the title "0.92/0.94 compatibility and HBASE-5206."  My issue is more with leaving in HBASE-5206 as is in 0.94.2 -- I probably should have posted on that JIRA.  Sorry about that.

My reading of this patch is that it will work whether we leave in HBASE-5206 or we do the change I propose on the e-mail (moving the enabled state to a different znode).  Do you agree, Ted/Lars?

One nit about the patch, the comment on the isEnabledTable function is no longer valid:
{code}
   * Go to zookeeper and see if state of table is {@link TableState#ENABLED}.
{code}

but the state doesn't have to be enabled, it can also be null (and should probably point to this JIRA to explain why both are valid?).
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446594#comment-13446594 ] 

Gregory Chanan commented on HBASE-6268:
---------------------------------------

patch lgtm.
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt, 6268-94.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6268) Can't enable a table on a 0.94 cluster from a 0.92 client

Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446237#comment-13446237 ] 

Gregory Chanan commented on HBASE-6268:
---------------------------------------

I'm not sure I agree with this patch.  I'll bring up something on the dev list.
                
> Can't enable a table on a 0.94 cluster from a 0.92 client
> ---------------------------------------------------------
>
>                 Key: HBASE-6268
>                 URL: https://issues.apache.org/jira/browse/HBASE-6268
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>             Fix For: 0.92.2
>
>         Attachments: 6268-92.txt
>
>
> In 0.92 we know a table's enabled by doing this in HCM.isEnabledTable:
> bq. return getTableState(zkw, tableName) == null;
> In 0.94 we do:
> bq. return getTableState(zkw, tableName) == TableState.ENABLED;
> So what happens is that the the 0.92 client will hang forever since the znode contains ENABLED instead of being absent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira