You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/08 02:11:48 UTC

[GitHub] [ozone] guihecheng opened a new pull request #2310: HDDS-5316. Fix datanode reserved space calculation.

guihecheng opened a new pull request #2310:
URL: https://github.com/apache/ozone/pull/2310


   ## What changes were proposed in this pull request?
   
   This tries to fix the datanode reserved space calculation, details in the issue description and code comments.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-5316
   
   ## How was this patch tested?
   
   existing ut.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] guihecheng commented on pull request #2310: HDDS-5316. Fix datanode reserved space calculation.

Posted by GitBox <gi...@apache.org>.
guihecheng commented on pull request #2310:
URL: https://github.com/apache/ozone/pull/2310#issuecomment-856409034


   @ChenSammi @bshashikant please help review this, thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] guihecheng commented on pull request #2310: HDDS-5316. Fix datanode reserved space calculation.

Posted by GitBox <gi...@apache.org>.
guihecheng commented on pull request #2310:
URL: https://github.com/apache/ozone/pull/2310#issuecomment-856670801


   @ChenSammi sure, will add more tests, thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi commented on pull request #2310: HDDS-5316. Fix datanode reserved space calculation.

Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2310:
URL: https://github.com/apache/ozone/pull/2310#issuecomment-861451323


   +1.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] guihecheng commented on pull request #2310: HDDS-5316. Fix datanode reserved space calculation.

Posted by GitBox <gi...@apache.org>.
guihecheng commented on pull request #2310:
URL: https://github.com/apache/ozone/pull/2310#issuecomment-858332943


   @ChenSammi updated with more tests, thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi commented on pull request #2310: HDDS-5316. Fix datanode reserved space calculation.

Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2310:
URL: https://github.com/apache/ozone/pull/2310#issuecomment-856660207


   Thanks @guihecheng for working on this.  The patch LGTM.  Can you please add a unit test for the space calculation? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi merged pull request #2310: HDDS-5316. Fix datanode reserved space calculation.

Posted by GitBox <gi...@apache.org>.
ChenSammi merged pull request #2310:
URL: https://github.com/apache/ozone/pull/2310


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org