You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/11 10:18:19 UTC

[GitHub] [iotdb] sunjincheng121 opened a new pull request #2674: Remove `final` if there are no subclasses by design.(Happy New Year)

sunjincheng121 opened a new pull request #2674:
URL: https://github.com/apache/iotdb/pull/2674


   Remove `final` if there are no subclasses by design, In this PR would like to using `static` take over `static final`. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sunjincheng121 merged pull request #2674: Remove `final` if there are no subclasses by design.(Happy New Year)

Posted by GitBox <gi...@apache.org>.
sunjincheng121 merged pull request #2674:
URL: https://github.com/apache/iotdb/pull/2674


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sunjincheng121 commented on pull request #2674: Remove `final` if there are no subclasses by design.(Happy New Year)

Posted by GitBox <gi...@apache.org>.
sunjincheng121 commented on pull request #2674:
URL: https://github.com/apache/iotdb/pull/2674#issuecomment-777519658


   Happy new year and Thanks for reviewing the PR @qiaojialin !
   I will merge this PR and track the check error of Ubuntu 11 in IOTDB-1155.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org