[GitHub] [spark] itholic commented on pull request #40420: [SPARK-42617][PS] Support `isocalendar` from the pandas 2.0.0

["itholic (via GitHub)" <gi...@apache.org>]

itholic commented on PR #40420:
URL: https://github.com/apache/spark/pull/40420#issuecomment-1726767540

   @dzhigimont Can we just make the CI pass for now? I can help in the follow-ups after merging this one.
   
   Seems like the mypy checks is failing for now:
   ```
   starting mypy annotations test...
   annotations failed mypy checks:
   python/pyspark/pandas/namespace.py:162: error: Cannot assign multiple types to name "_range" without an explicit "Type[...]" annotation  [misc]
   python/pyspark/pandas/indexes/base.py:2075: error: Unused "type: ignore" comment
   python/pyspark/pandas/indexes/base.py:2145: error: Unused "type: ignore" comment
   Found 3 errors in 2 files (checked 703 source files)
   ```
   
   To resolve them:
   - [ ] Remove "type: ignore" comment from python/pyspark/pandas/indexes/base.py:2075
   - [ ] Remove "type: ignore" comment from python/pyspark/pandas/indexes/base.py:2145
   - [ ] Add "# type: ignore" to python/pyspark/pandas/namespace.py:162


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org