[GitHub] [iceberg] nastra commented on issue #6711: REST-Catalog: `Table.newTransaction()....commit()` does nothing

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on issue #6711:
URL: https://github.com/apache/iceberg/issues/6711#issuecomment-1410842372

   Indeed this is missing the `commitTransaction() call. The below test passes for me:
   ```
   @Test
     public void testUpdatePropertiesViaTransaction() {
       C catalog = catalog();
   
       Table table = catalog.buildTable(TABLE, SCHEMA).create();
   
       Transaction transaction = table.newTransaction();
       transaction
           .updateProperties()
           .set(TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED, "true")
           .set(TableProperties.METADATA_PREVIOUS_VERSIONS_MAX, Integer.toString(23))
           .commit();
   
       transaction.commitTransaction();
   
       Table loaded = catalog.loadTable(TABLE);
       Assertions.assertThat(loaded.properties())
           .containsEntry(TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED, "true");
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org