You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ma...@hyperreal.org on 1999/12/01 06:09:19 UTC
cvs commit: apache-2.0/src/include ap_ac_config.h
manoj 99/11/30 21:09:19
Modified: src/include ap_ac_config.h
Log:
Autoconf's configure script will tell us which types select is looking
for; we might as well take advantage of it.
Revision Changes Path
1.2 +4 -3 apache-2.0/src/include/ap_ac_config.h
Index: ap_ac_config.h
===================================================================
RCS file: /home/cvs/apache-2.0/src/include/ap_ac_config.h,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -u -r1.1 -r1.2
--- ap_ac_config.h 1999/12/01 01:16:04 1.1
+++ ap_ac_config.h 1999/12/01 05:09:17 1.2
@@ -149,10 +149,11 @@
/* XXX - This probably doesn't handle OS/2 */
#ifdef SELECT_NEEDS_CAST
#define ap_select(_a, _b, _c, _d, _e) \
- select((_a), (int *)(_b), (int *)(_c), (int *)(_d), (_e))
+ select((SELECT_TYPE_ARG1)(_a), (SELECT_TYPE_ARG234)(_b), \
+ (SELECT_TYPE_ARG234)(_c), (SELECT_TYPE_ARG234)(_d), \
+ (SELECT_TYPE_ARG5)(_e))
#else
-#define ap_select(_a, _b, _c, _d, _e) \
- select(_a, _b, _c, _d, _e)
+#define ap_select(_a, _b, _c, _d, _e) select(_a, _b, _c, _d, _e)
#endif
/* So that we can use inline on some critical functions, and use
Re: cvs commit: apache-2.0/src/include ap_ac_config.h
Posted by Manoj Kasichainula <ma...@raleigh.ibm.com>.
On Wed, Dec 01, 1999 at 07:56:40AM -0500, Ryan Bloom wrote:
> We shouldn't be using select anymore in Apache. It should be using
> ap_poll, and ap_poll will figure out how to use select. So, this whole
> check shouldn't be necessary.
Most of the uses are in MPMs, so it's perfectly legitimate. I agree,
though, it would make definitely make things easier to switch.
But I'm focusing on making autoconf work with the existing code and
making sure it can do everything we want; except for the really easy
stuff, I'm not bothering with porting things to APR that would remove
Apache's autoconf checks yet.
--
Manoj Kasichainula - manojk@raleigh.ibm.com
IBM, Apache Development
Re: cvs commit: apache-2.0/src/include ap_ac_config.h
Posted by Ryan Bloom <rb...@raleigh.ibm.com>.
On 1 Dec 1999 manoj@hyperreal.org wrote:
> manoj 99/11/30 21:09:19
>
> Modified: src/include ap_ac_config.h
> Log:
> Autoconf's configure script will tell us which types select is looking
> for; we might as well take advantage of it.
We shouldn't be using select anymore in Apache. It should be using
ap_poll, and ap_poll will figure out how to use select. So, this whole
check shouldn't be necessary.
Ryan
_______________________________________________________________________
Ryan Bloom rbb@raleigh.ibm.com
4205 S Miami Blvd
RTP, NC 27709 It's a beautiful sight to see good dancers
doing simple steps. It's a painful sight to
see beginners doing complicated patterns.
Re: cvs commit: apache-2.0/src/include ap_ac_config.h
Posted by Ryan Bloom <rb...@raleigh.ibm.com>.
On 1 Dec 1999 manoj@hyperreal.org wrote:
> manoj 99/11/30 21:09:19
>
> Modified: src/include ap_ac_config.h
> Log:
> Autoconf's configure script will tell us which types select is looking
> for; we might as well take advantage of it.
We shouldn't be using select anymore in Apache. It should be using
ap_poll, and ap_poll will figure out how to use select. So, this whole
check shouldn't be necessary.
Ryan
_______________________________________________________________________
Ryan Bloom rbb@raleigh.ibm.com
4205 S Miami Blvd
RTP, NC 27709 It's a beautiful sight to see good dancers
doing simple steps. It's a painful sight to
see beginners doing complicated patterns.