[GitHub] [kafka] ConcurrencyPractitioner commented on issue #5012: KAFKA-4696: Streams standby task assignment should be state-store aware

["ConcurrencyPractitioner (GitHub)" <gi...@apache.org>]

Hi @vvcephei,

Could you point out where these ambiguous places are (the ones where its hard to differentiate between ```TaskId``` and ```TaskMetadata```)? Because when I scooted around in the code looking for places where such ambiguity could occur, I found that usually the version number could help you determine which to use. If its four or higher, ```TaskMetadata```, or else ```TaskId```. I might be missing something here, but I think the code is relatively understandable. An uninformed person should be able to figure out when ```TaskMetadata``` or ```TaskId``` would be used.

WDYT?

[ Full content available at: https://github.com/apache/kafka/pull/5012 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org