You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2023/01/19 11:10:04 UTC
[GitHub] [ozone] siddhantsangwan opened a new pull request, #4192: Hdds 7804
siddhantsangwan opened a new pull request, #4192:
URL: https://github.com/apache/ozone/pull/4192
## What changes were proposed in this pull request?
- Replicas with UNHEALTHY state will not count toward sufficient replication.
- A new constructor in RatisContainerReplicaCount that takes a list of ContainerReplicaOp. This is needed to ignore pending deletes on UNHEALTHY replicas.
- Ensure Legacy RM is not affected.
- New UTs.
- Disable a UT for now. It should be fixed when the rest of the tasks are in: https://issues.apache.org/jira/browse/HDDS-7785
- There is a discrepancy in the meaning of healthy replicas bw RatisContainerReplicaCount#isHealthy and getHealthyReplicaCount. This should be clear when the rest of the jiras are in.
Check the jira for a detailed description.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7785
## How was this patch tested?
New UTs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on a diff in pull request #4192: HDDS-7804. UNHEALTHY replicas will not contribute to sufficient replication in RatisContainerReplicaCount
Posted by GitBox <gi...@apache.org>.
sodonnel commented on code in PR #4192:
URL: https://github.com/apache/ozone/pull/4192#discussion_r1081183713
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/TestRatisOverReplicationHandler.java:
##########
@@ -154,6 +155,7 @@ public void testOverReplicatedQuasiClosedContainerWithDifferentOrigins()
* prioritize creating delete commands for unhealthy replicas over quasi
* closed replicas.
*/
+ @Ignore("HDDS-7804")
Review Comment:
If this test is no longer valid based on the changes here, probably best to remove it rather than just ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #4192: HDDS-7804. UNHEALTHY replicas will not contribute to sufficient replication in RatisContainerReplicaCount
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #4192:
URL: https://github.com/apache/ozone/pull/4192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4192: HDDS-7804. UNHEALTHY replicas will not contribute to sufficient replication in RatisContainerReplicaCount
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #4192:
URL: https://github.com/apache/ozone/pull/4192#issuecomment-1398442669
Thanks @siddhantsangwan for the patch, @sodonnel for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] siddhantsangwan commented on a diff in pull request #4192: HDDS-7804. UNHEALTHY replicas will not contribute to sufficient replication in RatisContainerReplicaCount
Posted by GitBox <gi...@apache.org>.
siddhantsangwan commented on code in PR #4192:
URL: https://github.com/apache/ozone/pull/4192#discussion_r1081589236
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/TestRatisOverReplicationHandler.java:
##########
@@ -154,6 +155,7 @@ public void testOverReplicatedQuasiClosedContainerWithDifferentOrigins()
* prioritize creating delete commands for unhealthy replicas over quasi
* closed replicas.
*/
+ @Ignore("HDDS-7804")
Review Comment:
Yeah, I think we need a similar test later on but in a different context. I've removed it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org