You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/31 12:24:52 UTC
[GitHub] [camel-k] squakez opened a new pull request, #3788: fix(trait): Camel trait as IntegrationKit
squakez opened a new pull request, #3788:
URL: https://github.com/apache/camel-k/pull/3788
Closes #3758
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
fix(trait): Camel trait as IntegrationKit
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #3788: fix(trait): Camel trait as IntegrationKit
Posted by GitBox <gi...@apache.org>.
squakez merged PR #3788:
URL: https://github.com/apache/camel-k/pull/3788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3788: fix(trait): Camel trait as IntegrationKit
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3788:
URL: https://github.com/apache/camel-k/pull/3788#discussion_r1010081175
##########
pkg/trait/trait_test.go:
##########
@@ -457,7 +457,7 @@ func TestConfigureVolumesAndMountsBinaryAndTextResources(t *testing.T) {
func TestOnlySomeTraitsInfluenceBuild(t *testing.T) {
c := NewTraitTestCatalog()
- buildTraits := []string{"builder", "quarkus", "registry"}
+ buildTraits := []string{"builder", "quarkus", "registry", "camel"}
Review Comment:
Same here.
##########
pkg/apis/camel/v1/integrationkit_types.go:
##########
@@ -77,7 +77,8 @@ type IntegrationKitTraits struct {
Quarkus *trait.QuarkusTrait `property:"quarkus" json:"quarkus,omitempty"`
// The Registry trait sets up Maven to use the Image registry as a Maven repository.
Registry *trait.RegistryTrait `property:"registry" json:"registry,omitempty"`
-
+ // The Camel trait sets up Camel configuration.
+ Camel *trait.CamelTrait `property:"camel" json:"camel,omitempty"`
Review Comment:
Nitpick: It'd be better to keep alphabetical order, which means Camel should be put between Builder and Quarkus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org