[jira] [Commented] (FOP-1196) [PATCH] GSoC: floats implementation

["Petter Reinholdtsen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FOP-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500316#comment-16500316 ] 

Petter Reinholdtsen commented on FOP-1196:
------------------------------------------

Hi.

Is there some reason why this patch haven't yet been integrated into
fop?  It would be great if also the free software fop formatter was
capable of handling floating sidebars. :)

-- 
Happy hacking
Petter Reinholdtsen


> [PATCH] GSoC: floats implementation
> -----------------------------------
>
>                 Key: FOP-1196
>                 URL: https://issues.apache.org/jira/browse/FOP-1196
>             Project: FOP
>          Issue Type: Improvement
>          Components: layout/unqualified
>    Affects Versions: trunk
>         Environment: Operating System: All
> Platform: All
>            Reporter: Vincent Hennebert
>            Priority: Major
>              Labels: PatchAvailable
>         Attachments: patch.diff, patch2.diff, patchBeforeFloats-2.diff, patchBeforeFloats.diff, patchDisabledTestcases.diff, patchTestcases.diff
>
>
> This patch isn't really meant to be applied... Rather to be reviewed by
> interested parties to check if I'm not wrong. Changelog:
> * javadocs for the Knuth line- and page-breaking algorithms. Some items are
> marked with double question marks because I haven't found out yet what is their
> purpose. I will probably find eventually, but if anybody has immediate hints
> they will be welcome.
> * some methods have been marked deprecated because AFAICT they are not called
> anywhere. If this is agreed I'll remove them in my next patch
> * bugfix? In the last for loop of the method
> layoutmgr.PageBreakingAlgorithm.noBreakBetween I think the exit condition should
> be a strict comparison ('<' instead of '<='). Confirmation?
> * the javadoc comments for some methods have been removed because they will
> inherit them from their super-class
> * some checkstyle fixes



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)