svn commit: r718340 - /webservices/commons/trunk/modules/transport/modules/base/src/main/java/org/apache/axis2/transport/base/AbstractTransportListener.java

[ve...@apache.org]

Author: veithen
Date: Mon Nov 17 11:35:15 2008
New Revision: 718340

URL: http://svn.apache.org/viewvc?rev=718340&view=rev
Log:
Avoid dumping a stacktrace at log level WARN when a service is disabled for a given transport. Indeed this happens whenever a service is deployed that has no configuration for that transport, which is quite frequent.

Modified:
    webservices/commons/trunk/modules/transport/modules/base/src/main/java/org/apache/axis2/transport/base/AbstractTransportListener.java

Modified: webservices/commons/trunk/modules/transport/modules/base/src/main/java/org/apache/axis2/transport/base/AbstractTransportListener.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/transport/modules/base/src/main/java/org/apache/axis2/transport/base/AbstractTransportListener.java?rev=718340&r1=718339&r2=718340&view=diff
==============================================================================
--- webservices/commons/trunk/modules/transport/modules/base/src/main/java/org/apache/axis2/transport/base/AbstractTransportListener.java (original)
+++ webservices/commons/trunk/modules/transport/modules/base/src/main/java/org/apache/axis2/transport/base/AbstractTransportListener.java Mon Nov 17 11:35:15 2008
@@ -205,7 +205,13 @@
                     transportName + " transport: " + ex.getMessage() + ". " + 
                     "This service is being marked as faulty and will not be available over the " +
                     transportName + " transport.";
-            log.warn(msg, ex);
+            // Only log the message at level WARN and log the full stack trace at level DEBUG.
+            // TODO: We should have a way to distinguish a missing configuration
+            //       from an error. This may be addressed when implementing the enhancement
+            //       described in point 3 of http://markmail.org/message/umhenrurlrekk5jh
+            log.warn(msg);
+            log.debug("Disabling service " + serviceName + " for the " + transportName +
+                    "transport", ex);
             BaseUtils.markServiceAsFaulty(serviceName, msg, service.getAxisConfiguration());
             disableTransportForService(service);
             return;