[jira] Commented: (RIVER-310) [patch] fix possible NPE due to incorrectly ordered if guard

["Peter Firmstone (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RIVER-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724846#action_12724846 ] 

Peter Firmstone commented on RIVER-310:
---------------------------------------

Thanks for the patches Dave,  I've been very busy lately so do apologize for the delay.

Thank you,

Peter.

> [patch] fix possible NPE due to incorrectly ordered if guard
> ------------------------------------------------------------
>
>                 Key: RIVER-310
>                 URL: https://issues.apache.org/jira/browse/RIVER-310
>             Project: River
>          Issue Type: Improvement
>         Environment: NA
>            Reporter: Dave Brosius
>            Assignee: Peter Firmstone
>            Priority: Trivial
>         Attachments: fix_possible_npe.diff
>
>
> Code improperly orders null length 0 guard, opening the possibility of a NPE
> patch fixes
> -	if ((name.length() == 0) || (name == null)) {
> +	if ((name == null) || (name.length() == 0)) {
>  	    throw new IOException("no name specified in preference" +
>  				  " expression");

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.