You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/11/24 04:57:08 UTC
[GitHub] [incubator-yunikorn-web] wilfred-s commented on a change in pull request #49: YUNIKORN-450: Better representation of memory and vcores in yunikorn web
wilfred-s commented on a change in pull request #49:
URL: https://github.com/apache/incubator-yunikorn-web/pull/49#discussion_r529202107
##########
File path: src/app/utils/common.util.ts
##########
@@ -33,18 +33,18 @@ export class CommonUtil {
let unit = 'MB';
let toValue = +value;
- if (toValue / 1024 >= 0.9) {
- toValue = toValue / 1024;
+ if (toValue / 1000 >= 1) {
+ toValue = toValue / 1000;
Review comment:
We need to be careful here: what do we get from the system? Is that MB or is it really MiB?
It goes all the way back to the shim, the core does not care and uses whatever it gets as the value without scales. If I read the shim code correctly it all gets converted to MB for memory and rounded into whole MB's (1000 * 1000 bytes).
Please confirm that I am reading the shim code correctly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org