[GitHub] [openwhisk-runtime-go] dgrove-oss commented on a diff in pull request #166: Add golang:1.18

[GitBox <gi...@apache.org>]

dgrove-oss commented on code in PR #166:
URL: https://github.com/apache/openwhisk-runtime-go/pull/166#discussion_r861904289


##########
CHANGES.md:
##########
@@ -16,6 +16,14 @@
 # limitations under the License.
 #
 -->
+# 1.19.0

Review Comment:
   Strictly speaking this should be "future release" and not 1.19.0 until the release process is started on the openwhisk-dev mailing list via an announcement of an intent to release



##########
golang1.18/Dockerfile:
##########
@@ -0,0 +1,52 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Do not fix the patch level for golang:1.17 to automatically get security fixes.

Review Comment:
   golang:1.18 in comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org