You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:00:43 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #15235: chore: Improves the Select component UI/UX - iteration 2
michael-s-molina opened a new pull request #15235:
URL: https://github.com/apache/superset/pull/15235
### SUMMARY
Improves the `Select` component UI/UX - iteration 2.
Storybook changes:
At Every Corner
- Adds a text explaining the objective of this panel
- Increases the selects width
Async Select
- Allows the user to simulate a slower connection
- Displays the dispatched requests
- Decreases the select width
Interactive Select
- Decreases the select width
Select component changes:
- Fixes a bug where the paginated scroll keeps requesting data if the user scrolls down and there is no more data available
- Moves `debounce` from handleFetch to `handleOnSearch`
- Renames the select
Improvements/tasks that will be made in the next iterations:
Async Select
- Make it more clear that the select is loading while scrolling
- Improve the error handling
Interactive Select
- Add the remaining properties
- Hide the options control
- When `allowNewOptions` is true, `showSearch` should be true
- Show radio group with no header, text header, and `ControlHeader`
Select component
- Check/Discuss whether we need the onPaste and on closeOnScrollOut props
- Remove the usage of any from the implementation
- Our interface should only expose single and multiple modes
- Paginate a few px before the bottom of the scroll for better UX
- Investigate why there are two `useEffects` with very similar dependencies and the same code
- Manual testing
- RTL tests
@geido @villebro @rusackas @junlincc @kgabryje The component continues to be isolated from the rest of the application. Only available in the Storybook. You don't need to test this PR, this will be done in the final iterations. The idea here is to share the current state of the work and give the opportunity to interact with the component and visualize potential improvements.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/70410625/122447287-f696c300-cf79-11eb-8528-dc1a0e24f53f.mov
https://user-images.githubusercontent.com/70410625/122447300-fa2a4a00-cf79-11eb-951c-4a7892dd4fa5.mov
### TESTING INSTRUCTIONS
Use the Select storybook to explore all the available options.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #15235: chore: Improves the Select component UI/UX - iteration 2
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #15235:
URL: https://github.com/apache/superset/pull/15235#issuecomment-866022707
@villebro About the "Create" when using `allowNewOptions`... I think @geido had a reason not to add this but I can't remember right now. @geido Do you remember?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15235: chore: Improves the Select component UI/UX - iteration 2
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15235:
URL: https://github.com/apache/superset/pull/15235#issuecomment-866254619
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #15235: chore: Improves the Select component UI/UX - iteration 2
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #15235:
URL: https://github.com/apache/superset/pull/15235#issuecomment-866022707
@villebro About the "Create" when using `allowNewOptions`... I think @geido had a reason to not add this but I can't remember right now. @geido Do you remember?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #15235: chore: Improves the Select component UI/UX - iteration 2
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #15235:
URL: https://github.com/apache/superset/pull/15235#issuecomment-866047639
Hi @villebro @michael-s-molina . The reason not to have the "Create" is because that would be inconsistent with the defaut Antd behavior which just presents you with the value. Changing the default behavior comes with an implementation cost and we did not see the added benefit for the end user very clearly. As long as the user can create new options, it should not matter whether he is creating one or picking an existing, unless you have a different opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15235: chore: Improves the Select component UI/UX - iteration 2
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15235:
URL: https://github.com/apache/superset/pull/15235#issuecomment-864284609
@pkdotson Ephemeral environment spinning up at http://34.221.205.16:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15235: chore: Improves the Select component UI/UX - iteration 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15235:
URL: https://github.com/apache/superset/pull/15235#issuecomment-863451528
# [Codecov](https://codecov.io/gh/apache/superset/pull/15235?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15235](https://codecov.io/gh/apache/superset/pull/15235?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a88abca) into [master](https://codecov.io/gh/apache/superset/commit/7237324983b91df7cc8dab051a95d244294d4d4f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7237324) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/15235?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15235 +/- ##
=======================================
Coverage 77.16% 77.17%
=======================================
Files 971 971
Lines 50243 50311 +68
Branches 6112 6141 +29
=======================================
+ Hits 38772 38828 +56
- Misses 11268 11279 +11
- Partials 203 204 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.79% <0.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15235?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/15235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/superset/pull/15235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | `66.66% <ø> (ø)` | |
| [superset-frontend/src/components/index.ts](https://codecov.io/gh/apache/superset/pull/15235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvaW5kZXgudHM=) | `0.00% <0.00%> (ø)` | |
| [...nfigModal/FiltersConfigForm/CollapsibleControl.tsx](https://codecov.io/gh/apache/superset/pull/15235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbGxhcHNpYmxlQ29udHJvbC50c3g=) | `91.30% <0.00%> (-8.70%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/15235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `96.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/15235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `90.42% <0.00%> (-0.40%)` | :arrow_down: |
| [...hboard/components/nativeFilters/FilterBar/utils.ts](https://codecov.io/gh/apache/superset/pull/15235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL3V0aWxzLnRz) | `75.00% <0.00%> (ø)` | |
| [...ters/FiltersConfigModal/FiltersConfigForm/utils.ts](https://codecov.io/gh/apache/superset/pull/15235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3V0aWxzLnRz) | `93.75% <0.00%> (+0.41%)` | :arrow_up: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/15235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `80.70% <0.00%> (+0.52%)` | :arrow_up: |
| [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/15235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `89.89% <0.00%> (+0.53%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/15235/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15235?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15235?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7237324...a88abca](https://codecov.io/gh/apache/superset/pull/15235?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on pull request #15235: chore: Improves the Select component UI/UX - iteration 2
Posted by GitBox <gi...@apache.org>.
pkdotson commented on pull request #15235:
URL: https://github.com/apache/superset/pull/15235#issuecomment-864283908
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #15235: chore: Improves the Select component UI/UX - iteration 2
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #15235:
URL: https://github.com/apache/superset/pull/15235#discussion_r656235747
##########
File path: superset-frontend/src/components/Select/Select.stories.tsx
##########
@@ -0,0 +1,313 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { ReactNode, useState, useCallback } from 'react';
+import Select, { SelectProps, OptionsPromiseResult } from './Select';
+
+export default {
+ title: 'Select',
+ component: Select,
+};
+
+const DEFAULT_WIDTH = 200;
+
+const options = [
+ {
+ label: 'Such an incredibly awesome long long label',
+ value: 'Such an incredibly awesome long long label',
+ },
+ {
+ label: 'Another incredibly awesome long long label',
+ value: 'Another incredibly awesome long long label',
+ },
+ { label: 'Just a label', value: 'Just a label' },
+ { label: 'A', value: 'A' },
+ { label: 'B', value: 'B' },
+ { label: 'C', value: 'C' },
+ { label: 'D', value: 'D' },
+ { label: 'E', value: 'E' },
+ { label: 'F', value: 'F' },
+ { label: 'G', value: 'G' },
+ { label: 'H', value: 'H' },
+ { label: 'I', value: 'I' },
+];
+
+const selectPositions = [
+ {
+ id: 'topLeft',
+ style: { top: '0', left: '0' },
+ },
+ {
+ id: 'topRight',
+ style: { top: '0', right: '0' },
+ },
+ {
+ id: 'bottomLeft',
+ style: { bottom: '0', left: '0' },
+ },
+ {
+ id: 'bottomRight',
+ style: { bottom: '0', right: '0' },
+ },
+];
+
+export const AtEveryCorner = () => (
+ <>
+ {selectPositions.map(position => (
+ <div
+ key={position.id}
+ style={{
+ ...position.style,
+ width: DEFAULT_WIDTH,
+ position: 'absolute',
+ }}
+ >
+ <Select ariaLabel={`gallery-${position.id}`} options={options} />
+ </div>
+ ))}
+ <p style={{ position: 'absolute', top: '40%', left: '33%', width: 500 }}>
+ The objective of this panel is to show how the Select behaves when in
+ touch with the viewport extremities. In particular, how the drop-down is
+ displayed and if the tooltips of truncated items are correctly positioned.
+ </p>
Review comment:
Great point. I'll do it in the next iteration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #15235: chore: Improves the Select component UI/UX - iteration 2
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #15235:
URL: https://github.com/apache/superset/pull/15235#discussion_r656223790
##########
File path: superset-frontend/src/components/Select/Select.stories.tsx
##########
@@ -0,0 +1,313 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { ReactNode, useState, useCallback } from 'react';
+import Select, { SelectProps, OptionsPromiseResult } from './Select';
+
+export default {
+ title: 'Select',
+ component: Select,
+};
+
+const DEFAULT_WIDTH = 200;
+
+const options = [
+ {
+ label: 'Such an incredibly awesome long long label',
+ value: 'Such an incredibly awesome long long label',
+ },
+ {
+ label: 'Another incredibly awesome long long label',
+ value: 'Another incredibly awesome long long label',
+ },
+ { label: 'Just a label', value: 'Just a label' },
+ { label: 'A', value: 'A' },
+ { label: 'B', value: 'B' },
+ { label: 'C', value: 'C' },
+ { label: 'D', value: 'D' },
+ { label: 'E', value: 'E' },
+ { label: 'F', value: 'F' },
+ { label: 'G', value: 'G' },
+ { label: 'H', value: 'H' },
+ { label: 'I', value: 'I' },
+];
+
+const selectPositions = [
+ {
+ id: 'topLeft',
+ style: { top: '0', left: '0' },
+ },
+ {
+ id: 'topRight',
+ style: { top: '0', right: '0' },
+ },
+ {
+ id: 'bottomLeft',
+ style: { bottom: '0', left: '0' },
+ },
+ {
+ id: 'bottomRight',
+ style: { bottom: '0', right: '0' },
+ },
+];
+
+export const AtEveryCorner = () => (
+ <>
+ {selectPositions.map(position => (
+ <div
+ key={position.id}
+ style={{
+ ...position.style,
+ width: DEFAULT_WIDTH,
+ position: 'absolute',
+ }}
+ >
+ <Select ariaLabel={`gallery-${position.id}`} options={options} />
+ </div>
+ ))}
+ <p style={{ position: 'absolute', top: '40%', left: '33%', width: 500 }}>
+ The objective of this panel is to show how the Select behaves when in
+ touch with the viewport extremities. In particular, how the drop-down is
+ displayed and if the tooltips of truncated items are correctly positioned.
+ </p>
Review comment:
It would also be nice to have a story where the select can scroll
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #15235: chore: Improves the Select component UI/UX - iteration 2
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #15235:
URL: https://github.com/apache/superset/pull/15235#issuecomment-864341621
For reference, the prior iteration is here: https://github.com/apache/superset/pull/15121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #15235: chore: Improves the Select component UI/UX - iteration 2
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged pull request #15235:
URL: https://github.com/apache/superset/pull/15235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org