You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "sketchturner (via GitHub)" <gi...@apache.org> on 2024/12/18 22:41:56 UTC

[I] Breaking change to FileAppender in a third-digit release (logging-log4net)

sketchturner opened a new issue, #216:
URL: https://github.com/apache/logging-log4net/issues/216

   A change to `FileAppender` that breaks backward compatibility was introduced with #196.
   `SetQWForFiles` is a publicly visible method that was renamed to `SetQwForFiles`. Need to rename it back in order to keep types that extend `FileAppender` compatible with the latest version of log4net


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Breaking change to FileAppender in a third-digit release (logging-log4net)

Posted by "sketchturner (via GitHub)" <gi...@apache.org>.
sketchturner commented on issue #216:
URL: https://github.com/apache/logging-log4net/issues/216#issuecomment-2553819330

   @FreeAndNil Great. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Breaking change to FileAppender in a third-digit release (logging-log4net)

Posted by "sketchturner (via GitHub)" <gi...@apache.org>.
sketchturner commented on issue #216:
URL: https://github.com/apache/logging-log4net/issues/216#issuecomment-2553719397

   @FreeAndNil thanks. I can wait for a stable release of version 3.0.4.
   By the way, is it by any chance possible to amend the message of the commit that was the result of #217 completion in order to remove the "Co-authored-by" part? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Breaking change to FileAppender in a third-digit release (logging-log4net)

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on issue #216:
URL: https://github.com/apache/logging-log4net/issues/216#issuecomment-2552414961

   I don't think we should keep BC outside of log4-api, but that's just me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Breaking change to FileAppender in a third-digit release (logging-log4net)

Posted by "FreeAndNil (via GitHub)" <gi...@apache.org>.
FreeAndNil closed issue #216: Breaking change to FileAppender in a third-digit release
URL: https://github.com/apache/logging-log4net/issues/216


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Breaking change to FileAppender in a third-digit release (logging-log4net)

Posted by "FreeAndNil (via GitHub)" <gi...@apache.org>.
FreeAndNil commented on issue #216:
URL: https://github.com/apache/logging-log4net/issues/216#issuecomment-2552897936

   @sketchturner thanks.
   Do you need a preview version of log4net?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Breaking change to FileAppender in a third-digit release (logging-log4net)

Posted by "FreeAndNil (via GitHub)" <gi...@apache.org>.
FreeAndNil commented on issue #216:
URL: https://github.com/apache/logging-log4net/issues/216#issuecomment-2553797991

   > By the way, is it by any chance possible to amend the message of the commit that was the result of #217 completion in order to remove the "Co-authored-by" part? Thanks
   
   @sketchturner see https://github.com/apache/logging-log4net/commit/e78f9e3bd6f342e3c35e314c553ab3e3c09fd605


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Breaking change to FileAppender in a third-digit release (logging-log4net)

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on issue #216:
URL: https://github.com/apache/logging-log4net/issues/216#issuecomment-2553532362

   > > I don't think we should keep BC outside of log4-api, but that's just me.
   > 
   > @garydgregory log4net is monolithic, we have no separate api (as log4j).
   
   Well, please accept my apologies and ignore my comment because I thought this was a log4j thread! 🤦 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Breaking change to FileAppender in a third-digit release (logging-log4net)

Posted by "FreeAndNil (via GitHub)" <gi...@apache.org>.
FreeAndNil commented on issue #216:
URL: https://github.com/apache/logging-log4net/issues/216#issuecomment-2552895685

   > I don't think we should keep BC outside of log4-api, but that's just me.
   @garydgregory log4net is monolithic, we have no separate api (as log4j).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org