[GitHub] [helix] narendly commented on a change in pull request #1705: Disable CORS by default in Helix REST

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #1705:
URL: https://github.com/apache/helix/pull/1705#discussion_r618953987



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/HelixRestServer.java
##########
@@ -164,7 +165,10 @@ protected ResourceConfig getResourceConfig(HelixRestNamespace namespace, Servlet
     }
     cfg.property(ContextPropertyKeys.METADATA.name(), namespace);
 
-    cfg.register(new CORSFilter());
+    if (Boolean.getBoolean(CORS_ENABLED)) {

Review comment:
       https://docs.oracle.com/javase/8/docs/api/java/lang/Boolean.html#getBoolean-java.lang.String-
   
   It gets it from System Properties by the string key provided. So if the key-value pair is defined in System.Properties, this will evaluate to `true`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org