You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Dmitriy Setrakyan (JIRA)" <ji...@apache.org> on 2017/09/08 02:56:00 UTC
[jira] [Comment Edited] (IGNITE-6064) Rework control.sh script
[ https://issues.apache.org/jira/browse/IGNITE-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158057#comment-16158057 ]
Dmitriy Setrakyan edited comment on IGNITE-6064 at 9/8/17 2:55 AM:
-------------------------------------------------------------------
I think we need to fix the format of the error messages.
{{10.116.206.1:11214 - was activate}} should be {{10.116.206.1:11214 - activated}}
The error messages do not follow the Ignite format.
{{Something fail during activation, exception message:}} should be {{Activation failed:}}
Not sure how the initial messages passed the code review. Let's make sure we fix them.
was (Author: dsetrakyan):
I think we need to fix the format of the error messages.
{{10.116.206.1:11214 - was activate}} should be {{10.116.206.1:11214 - activated}}
The error messages do not follow the Ignite format.
{{Something fail during activation, exception message:}} should be {{Activation failed: }}
Not sure how the initial messages passed the code review. Let's make sure we fix them.
> Rework control.sh script
> ------------------------
>
> Key: IGNITE-6064
> URL: https://issues.apache.org/jira/browse/IGNITE-6064
> Project: Ignite
> Issue Type: Improvement
> Components: general
> Affects Versions: 2.0, 2.1
> Reporter: Dmitriy Govorukhin
> Labels: usability
> Fix For: 2.3
>
>
> Current behavior control.sh is not clear.
> 1. control.sh is a confusing name, need more suitable name.
> 2. Print help description if incorrect command was entered
> 3. Do not print stacktrace if connection fail, add more conveniently message.
> 4. Print information about connection, like "Connecting to [ip-address]:[port] etc."
> 5. Document the usage on a special page. Ping Denis Magda when it's time to do that.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)