You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/03/21 13:57:35 UTC

[GitHub] [arrow] mapleFU commented on pull request #34555: GH-34556: [C++] Add prefix 'ACT_' for 'arrow::Compression::type' to avoid naming conflicts

mapleFU commented on PR #34555:
URL: https://github.com/apache/arrow/pull/34555#issuecomment-1477885050

   https://github.com/apache/arrow/pull/34555#issuecomment-1475533675 @deepzliu Sorry for previously misunderstand this patch. Seems that rocksdb uses code like:
   
   ```
   #ifdef SNAPPY
   #include <snappy.h>
   #endif
   
   #ifdef ZLIB
   #include <zlib.h>
   #endif
   ```
   
   And it conflict with arrow's definition. @kou What's the style for arrow's enum? Can we just use `kZStd` or use the fixing in this patch? And would it effect the C and other languages api?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org