[GitHub] [brooklyn-server] jcabrerizo commented on a diff in pull request #1310: Adds new `isArm` method to the OsDetails interface defaulting to false

[GitBox <gi...@apache.org>]

jcabrerizo commented on code in PR #1310:
URL: https://github.com/apache/brooklyn-server/pull/1310#discussion_r859607443


##########
core/src/main/java/org/apache/brooklyn/core/location/BasicOsDetails.java:
##########
@@ -96,6 +97,11 @@ public String toString() {
                 .toString();
     }
 
+    @Override
+    public boolean isArm() {
+        return getArch()!=null && Pattern.matches(ARM_ARCH_PATTERNS,getArch().toLowerCase());
+    }
+
     public static class OsNames {

Review Comment:
   It is not used in the project, but is a public class as the same `OsVersions`, I din't want to delete just in case someone used it in other project.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org