[jira] [Commented] (MESOS-85) Need to update semantics of MESOS_HOME

["jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234870#comment-13234870 ] 

jiraposter@reviews.apache.org commented on MESOS-85:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Summary
-------

Removes most remaining uses of MESOS_HOME from the tree.

Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).

After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.


This addresses bug MESOS-85.
    https://issues.apache.org/jira/browse/MESOS-85


Diffs
-----

  src/tests/external_tests.cpp 21fa705 
  src/slave/slave.cpp 9332caa 
  src/slave/webui.cpp 9f45442 
  src/tests/configurator_tests.cpp 662e01f 
  src/sched/sched.cpp 16770a1 
  src/slave/lxc_isolation_module.cpp 8c25dd4 
  src/slave/main.cpp ac780c4 
  src/slave/process_based_isolation_module.cpp e0f3ee8 
  src/master/main.cpp a8fadc9 
  src/mesos/main.cpp bbdb981 
  src/launcher/main.cpp 5c55ace 
  src/local/main.cpp d4b68a9 
  src/launcher/launcher.cpp 98a4847 
  src/launcher/launcher.hpp 221094f 
  src/deploy/mesos-env.sh 9f93a41 
  src/deploy/mesos-daemon 2e75d04 
  src/configurator/configurator.hpp a3a104f 
  src/configurator/configurator.cpp 2666e50 
  src/common/logging.cpp 9e346f2 

Diff: https://reviews.apache.org/r/4434/diff


Testing
-------

make check


Thanks,

Charles


                
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
>                 Key: MESOS-85
>                 URL: https://issues.apache.org/jira/browse/MESOS-85
>             Project: Mesos
>          Issue Type: Improvement
>          Components: build, master, slave, test
>            Reporter: Benjamin Hindman
>            Assignee: Charles Reiss
>            Priority: Blocker
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to represent where the slave should store it's "work" directory, where the slave expects "killtree" to be, where the master and slave should put logging, where the tests assume certain scripts live, etc. In practice this has meant that if mesos gets installed at /usr/local/mesos, then slave work directories go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed so that it only represents where binaries live, but not where things like work directories exist, logs go, etc. In addition, the testing infrastructure should get updated so that the external tests can find the scripts they need to run things *without* needing MESOS_HOME while still supporting a remote build directory.
> This issue is tagged as a blocker because in order to do the port to autotools cleanly, this really needs to get done in order to run the external tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira