You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/06/22 00:26:58 UTC

[GitHub] [trafficserver] masaori335 commented on a change in pull request #7949: Cleanup: Constify MIMEHdr

masaori335 commented on a change in pull request #7949:
URL: https://github.com/apache/trafficserver/pull/7949#discussion_r655791504



##########
File path: proxy/hdrs/MIME.h
##########
@@ -1790,7 +1790,7 @@ MIMEHdr::get_cooked_pragma_no_cache()
   -------------------------------------------------------------------------*/
 
 inline void
-MIMEHdr::set_cooked_cc_need_revalidate_once()
+MIMEHdr::set_cooked_cc_need_revalidate_once() // NOLINT(readability-make-member-function-const)

Review comment:
       @bryancall This is a good example. The `readability-make-member-function-const` suggests make this const function, but this is changing the `m_mask`.
   If we run `clang-tidy` with `readability-make-member-function-const`, we need to check all suggestions. :(




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org