[GitHub] [dolphinscheduler] stalary commented on a diff in pull request #11490: [Fix] Delete task definition when delete workflow

[GitBox <gi...@apache.org>]

stalary commented on code in PR #11490:
URL: https://github.com/apache/dolphinscheduler/pull/11490#discussion_r946296049


##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/TaskDefinitionMapper.xml:
##########
@@ -86,6 +86,14 @@
         delete from t_ds_task_definition
         where code = #{code}
     </delete>
+
+    <delete id="deleteByCodeList">
+        delete from t_ds_task_definition
+        where code in
+        <foreach collection="codeList" item="code" separator="," open="(" close=")">
+            #{code}
+        </foreach>
+    </delete>

Review Comment:
   It looks like process only delete the definition, do we need to unified?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org