You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/11/18 17:10:57 UTC

[GitHub] [mynewt-artifact] nkaje commented on a change in pull request #30: image: Support legacy TLV values via option

nkaje commented on a change in pull request #30:
URL: https://github.com/apache/mynewt-artifact/pull/30#discussion_r526259340



##########
File path: image/image.go
##########
@@ -750,9 +750,15 @@ func DecryptHw(img Image, secret []byte) (Image, error) {
 
 	tlvs := dup.FindProtTlvs(IMAGE_TLV_AES_NONCE)
 	if len(tlvs) != 1 {
-		return dup, errors.Errorf(
-			"failed to decrypt hw-encrypted image: "+
-				"wrong count of AES nonce TLVs; have=%d want=1", len(tlvs))
+		// try to find legact TLV

Review comment:
       minor/nit: typo in "legacy"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org