You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by bryancall <gi...@git.apache.org> on 2016/02/05 21:29:52 UTC
[GitHub] trafficserver pull request: TS-4177: Memory leak in LogFieldAliasT...
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/456
TS-4177: Memory leak in LogFieldAliasTable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver ts-4177
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #456
----
commit 88c197e585d51a37728baf86ea1d09ffd44147e5
Author: Bryan Call <bc...@apache.org>
Date: 2016-02-05T20:29:04Z
TS-4177: Memory leak in LogFieldAliasTable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4177: Memory leak in LogFieldAliasT...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/456#issuecomment-181463542
As far as I know, we can't depend on `std::unique_ptr` being available. If that's changed then yes, we could replace `ats_scoped_str` with `unique_ptr`. The former is limited basically for this reason, that it is just a stop gap until we can use the standard mechanism.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4177: Memory leak in LogFieldAliasT...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/456#issuecomment-181455689
If we want to go down the path of managed pointers then unique_ptr would be the way to go.
I don't see a benefit of ats_scopted_str. It not a generic class and has limited usability.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4177: Memory leak in LogFieldAliasT...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/456#issuecomment-180551999
+1. Btw, is that really how clang-format indented it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4177: Memory leak in LogFieldAliasT...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/456#issuecomment-181417642
Too late but this is the kind of thing {{ats_scoped_str}} is for.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4177: Memory leak in LogFieldAliasT...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/456
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4177: Memory leak in LogFieldAliasT...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/456#issuecomment-180567023
No, I didn't run clang-format on the pull request before pushing it to github. I have a script that automates committing pull requests and it will format it before it is pushed to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---