You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/28 09:07:10 UTC
[GitHub] [spark] cxzl25 opened a new pull request, #36710: [SPARK-39261][CORE][FOLLOWUP] Improve newline formatting for error messages
cxzl25 opened a new pull request, #36710:
URL: https://github.com/apache/spark/pull/36710
### What changes were proposed in this pull request?
Use `java.nio.file.Files.delete` instead of `org.apache.commons.io.FileUtils#delete`
### Why are the changes needed?
`org.apache.commons.io.FileUtils#delete` is a method only available in version 2.9, hadoop2 uses version 2.4 of commons-io.
Build failed
```
./dev/make-distribution.sh --tgz -Pyarn -Phive -Phive-thriftserver -Phadoop-2 -DskipTests -Dmaven.javadoc.skip=true
```
```
spark/core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala:92: value delete is not a member of object org.apache.commons.io.FileUtils
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
exist UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #36710: [SPARK-39261][CORE][FOLLOWUP] Improve newline formatting for error messages
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36710:
URL: https://github.com/apache/spark/pull/36710#issuecomment-1140324924
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #36710: [SPARK-39261][CORE][FOLLOWUP] Improve newline formatting for error messages
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #36710: [SPARK-39261][CORE][FOLLOWUP] Improve newline formatting for error messages
URL: https://github.com/apache/spark/pull/36710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #36710: [SPARK-39261][CORE][FOLLOWUP] Improve newline formatting for error messages
Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #36710:
URL: https://github.com/apache/spark/pull/36710#issuecomment-1140355557
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org