You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/27 14:34:17 UTC

[GitHub] [arrow] bkietz commented on pull request #8536: ARROW-10399: [R] Fix performance regression from cpp11::r_string

bkietz commented on pull request #8536:
URL: https://github.com/apache/arrow/pull/8536#issuecomment-717286906


   The only other usage of `cpp11::r_string` which I see that might be problematic is in [array_from_vector](https://github.com/apache/arrow/blob/3b461625505c621557c28226d5260b1d0c55e4fb/r/src/array_from_vector.cpp#L178) where it's used to translate each string element to utf8. It appears that code path is only taken for string (and binary) arrays which are nested inside other arrays as a dictionary, list item column, ... Repairing this can probably wait for a follow up in which we apply the framework introduced in #8088 to clean up conversion for R. @kszucs 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org