[GitHub] [incubator-kyuubi] Yikf commented on a diff in pull request #3476: [KYUUBI #3449] Change default server info provider to ENGINE

[GitBox <gi...@apache.org>]

Yikf commented on code in PR #3476:
URL: https://github.com/apache/incubator-kyuubi/pull/3476#discussion_r967830413


##########
kyuubi-server/src/test/scala/org/apache/kyuubi/operation/KyuubiOperationPerUserSuite.scala:
##########
@@ -37,6 +37,7 @@ class KyuubiOperationPerUserSuite
 
   override protected val conf: KyuubiConf = {
     KyuubiConf().set(KyuubiConf.ENGINE_SHARE_LEVEL, "user")
+    KyuubiConf().set(KyuubiConf.SERVER_INFO_PROVIDER, "SERVER")

Review Comment:
   test used to check server info, i think we should change default value in this test class?
   https://github.com/apache/incubator-kyuubi/blob/3905225aebe68672ce8ea3183dd7863418ef14fd/kyuubi-server/src/test/scala/org/apache/kyuubi/operation/KyuubiOperationPerUserSuite.scala#L47-L56



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org