You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2025/01/24 19:37:01 UTC
[PR] Add icons to task states [airflow]
bbovenzi opened a new pull request, #46028:
URL: https://github.com/apache/airflow/pull/46028
Update `stateColor` to match an icon to each task instance state and try to use those icons with those states when possible.
Part of: #43054
<img width="1423" alt="Screenshot 2025-01-24 at 2 16 34 PM" src="https://github.com/user-attachments/assets/074c4550-3247-4506-84d2-4bdbac6e5cf4" />
<img width="1015" alt="Screenshot 2025-01-24 at 2 16 44 PM" src="https://github.com/user-attachments/assets/15b2dad3-f8ea-45ec-86cc-1a1b7058dcd9" />
After this PR, I want to add color palettes for each task state and then consolidate our uses of Badges and Tags to make them all visually the same.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add icons to task states [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #46028:
URL: https://github.com/apache/airflow/pull/46028#issuecomment-2613562091
I moved all the colors into the app theme file to support semantic tokens and color palettes. I think there's still some tag/badge/status components that can be consolidated to improve consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add icons to task states [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #46028:
URL: https://github.com/apache/airflow/pull/46028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add icons to task states [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #46028:
URL: https://github.com/apache/airflow/pull/46028#issuecomment-2614573801
NIIIIIIIICE!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org