[GitHub] [incubator-pinot] snleee opened a new issue #4264: Remove Thrift dependency from Pinot

[GitBox <gi...@apache.org>]

snleee opened a new issue #4264: Remove Thrift dependency from Pinot
URL: https://github.com/apache/incubator-pinot/issues/4264
 
 
   Currently, we include auto-generated code from Thrift in our code base. Whenever we make the change to `request.thrift, response.thrift` file, we need to merge a large code change for auto generated classes. 
   
   One way to avoid this is to compile `.thrift` file locally; however, maven thrift plugin requires `thrift` to be available locally. To make the problem worse, thrift is written in c++ and I personally found that it's not trivial to build thrift from source code.
   
   So with thrift, we should choose either one.
   1. Keep the current way (whenever modify thrift file, check in large change for auto generated files)
   2. Remove auto generated file and make `installing thrift on local machine` to be pre-requisite to build Pinot.
   
   In my opinion, we should avoid both but it's not feasible with thrift.
   
   In the long term, we should migrate towards `protobuf, grpc` or some other similar rpc framework that doesn't have this issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org