You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/13 08:12:25 UTC

[jira] [Commented] (BOOKKEEPER-920) Extend bk-merge-pr.py to add more info to Jira ticket when merging

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238674#comment-15238674 ] 

ASF GitHub Bot commented on BOOKKEEPER-920:
-------------------------------------------

GitHub user merlimat opened a pull request:

    https://github.com/apache/bookkeeper/pull/36

    BOOKKEEPER-920: Extend bk-merge-pr.py to add more info to Jira ticket…

    … when merging

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merlimat/bookkeeper bk-920

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
    
----
commit 2738857f688316dea82e95d548c4491c87dd177c
Author: user.email <mm...@apache.org>
Date:   2016-04-13T06:10:45Z

    BOOKKEEPER-920: Extend bk-merge-pr.py to add more info to Jira ticket when merging

----


> Extend bk-merge-pr.py to add more info to Jira ticket when merging
> ------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-920
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-920
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Matteo Merli
>            Assignee: Matteo Merli
>            Priority: Minor
>             Fix For: 4.4.0
>
>
> We should add more information to the Jira ticket when merging a github PR. 
> Currently, the update on the Jira contains only the author and commit title. It would be good to also have:
>   * Author
>   * Committer
>   * Reviewers (Better if we automatically read the '+1' from the PR comments)
>  
> In addition, we should add the option to run the tests locally on the merged PR before pushing to apache git. 
> Recently we had cases of PRs which were fine on their own, but then tests started failing after merging into master (because of other commits since), even without git merge conflicts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)