You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2025/01/02 12:54:52 UTC
[PR] HDDS-11819. Improve mock datanode version handling in MiniOzoneCluster [ozone]
adoroszlai opened a new pull request, #7632:
URL: https://github.com/apache/ozone/pull/7632
HDDS-11819. Improve mock datanode version handling in MiniOzoneCluster
## What changes were proposed in this pull request?
`MiniOzoneCluster` allows setting custom "initial" and "current" version for datanodes in integration tests.
This PR:
- Moves the logic to `DatanodeFactory`, where similar logic for setting layout version already exists.
- Replaces mocked static methods with test-specific config properties to inject the custom value. This allows future implementation of the factory to set different version for each node.
- Removes `TestDatanodeVersion`, which duplicates `TestBlockDataStreamOutput#testDatanodeVersion`.
https://issues.apache.org/jira/browse/HDDS-11819
## How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/12581758034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11819. Improve mock datanode version handling in MiniOzoneCluster [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7632:
URL: https://github.com/apache/ozone/pull/7632#issuecomment-2569262646
Thanks @jojochuang, @smengcl for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11819. Improve mock datanode version handling in MiniOzoneCluster [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7632:
URL: https://github.com/apache/ozone/pull/7632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org