You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by apovzner <gi...@git.apache.org> on 2016/03/05 02:11:22 UTC

[GitHub] kafka pull request: KAFKA-3303: Pass partial record metadata to Pr...

GitHub user apovzner opened a pull request:

    https://github.com/apache/kafka/pull/1015

    KAFKA-3303: Pass partial record metadata to ProducerInterceptor.onAcknowledgement on error

    This is a KIP-42 followup. 
    
    Currently, If sending the record fails before it gets to the server, ProducerInterceptor.onAcknowledgement() is called with metadata == null, and non-null exception. However, it is useful to pass topic and partition, if known, to ProducerInterceptor.onAcknowledgement() as well. This patch ensures that  ProducerInterceptor.onAcknowledgement()  gets record metadata with topic and maybe partition. If partition is not set in 'record' and KafkaProducer.send() fails before partition gets assigned, then ProducerInterceptor.onAcknowledgement() gets RecordMetadata with partition == -1. Only time when  ProducerInterceptor.onAcknowledgement() gets null record metadata is when the client passes null record to KafkaProducer.send().

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apovzner/kafka kip42-3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1015.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1015
    
----
commit 169085a6b502d9458f477030cd6045f20b0100a7
Author: Anna Povzner <an...@confluent.io>
Date:   2016-03-05T01:05:56Z

    KAFKA-3303: Pass partial record metadata to Interceptor onAcknowledgement in case of errors

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: KAFKA-3303: Pass partial record metadata to Pr...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1015


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---