You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/09 14:28:19 UTC

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #15941: [fix][broker]Fix topic policies update not check message expiry

codelipenghui commented on code in PR #15941:
URL: https://github.com/apache/pulsar/pull/15941#discussion_r893578160


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -3026,7 +3026,7 @@ public void onUpdate(TopicPolicies policies) {
             updateSubscribeRateLimiter();
             replicators.forEach((name, replicator) -> replicator.getRateLimiter()
                     .ifPresent(DispatchRateLimiter::updateDispatchRate));
-
+            checkMessageExpiry();

Review Comment:
   Is it able to add a test to avoid regression?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org