[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6615: feat: new concatenation operator for working with arrays

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6615:
URL: https://github.com/apache/arrow-datafusion/pull/6615#discussion_r1225834512


##########
datafusion/core/tests/sqllogictests/test_files/array.slt:
##########
@@ -204,3 +204,21 @@ query II rowsort
 select array_ndims(array_fill(1, [1, 2, 3])), array_ndims([[[[[[[[[[[[[[[[[[[[[1]]]]]]]]]]]]]]]]]]]]]);
 ----
 3 21
+
+# array concatenate operator #1 (like array_concat scalar function)

Review Comment:
   I recommend adding a test for `null handling in these arrays 
   
   like 
   
   ```sql
   select make_array(1, 2, 3) || make_array(4, null, 6);
   ```
   
   and
   
   ```sql
   select make_array(1, 2, 3) || null;
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org