You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by nv...@apache.org on 2022/04/29 14:16:52 UTC

[cloudstack] branch revert-6335-fixdetailsbuttonsalign created (now 8a19a22c5b)

This is an automated email from the ASF dual-hosted git repository.

nvazquez pushed a change to branch revert-6335-fixdetailsbuttonsalign
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


      at 8a19a22c5b Revert "UI: Fix detail settings (#6335)"

This branch includes the following new commits:

     new 8a19a22c5b Revert "UI: Fix detail settings (#6335)"

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[cloudstack] 01/01: Revert "UI: Fix detail settings (#6335)"

Posted by nv...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

nvazquez pushed a commit to branch revert-6335-fixdetailsbuttonsalign
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 8a19a22c5b1dd9b7b46310323e93ba97fb6742e8
Author: Nicolas Vazquez <ni...@gmail.com>
AuthorDate: Fri Apr 29 11:16:42 2022 -0300

    Revert "UI: Fix detail settings (#6335)"
    
    This reverts commit e0487c43fb9758d153b8b9d670d84e68f400443e.
---
 ui/src/components/view/DetailSettings.vue   |  4 ++--
 ui/src/components/widgets/TooltipButton.vue | 10 +++-------
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/ui/src/components/view/DetailSettings.vue b/ui/src/components/view/DetailSettings.vue
index 57c5343ab7..276f99093d 100644
--- a/ui/src/components/view/DetailSettings.vue
+++ b/ui/src/components/view/DetailSettings.vue
@@ -56,8 +56,8 @@
             :options="detailValues"
             :placeholder="$t('label.value')"
             @change="e => onAddInputChange(e, 'newValue')" />
-          <tooltip-button :tooltip="$t('label.add.setting')" :shape="null" icon="check-outlined" @onClick="addDetail" buttonClass="detail-button" />
-          <tooltip-button :tooltip="$t('label.cancel')" :shape="null" icon="close-outlined" @onClick="closeDetail" buttonClass="detail-button" />
+          <tooltip-button :tooltip="$t('label.add.setting')" icon="check-outlined" @onClick="addDetail" buttonClass="detail-button" />
+          <tooltip-button :tooltip="$t('label.cancel')" icon="close-outlined" @onClick="closeDetail" buttonClass="detail-button" />
         </a-input-group>
         <p v-if="error" style="color: red"> {{ $t(error) }} </p>
       </div>
diff --git a/ui/src/components/widgets/TooltipButton.vue b/ui/src/components/widgets/TooltipButton.vue
index fa82130217..c0a2a467f2 100644
--- a/ui/src/components/widgets/TooltipButton.vue
+++ b/ui/src/components/widgets/TooltipButton.vue
@@ -20,10 +20,10 @@
     <template #title v-if="tooltip">
       {{ tooltip }}
     </template>
-    <span>
+    <span style="margin-right: 5px">
       <a-button
         v-if="copyResource"
-        :shape="shape"
+        shape="circle"
         :size="size"
         :type="type"
         :danger="danger"
@@ -39,7 +39,7 @@
       </a-button>
       <a-button
         v-else
-        :shape="shape"
+        shape="circle"
         :size="size"
         :type="type"
         :danger="danger"
@@ -108,10 +108,6 @@ export default {
     danger: {
       type: Boolean,
       default: false
-    },
-    shape: {
-      type: String,
-      default: 'circle'
     }
   },
   methods: {