You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "AnandInguva (via GitHub)" <gi...@apache.org> on 2023/03/28 19:37:36 UTC
[GitHub] [beam] AnandInguva opened a new pull request, #26019: Update pip-licenses in Dockerfile to support Python 3.11
AnandInguva opened a new pull request, #26019:
URL: https://github.com/apache/beam/pull/26019
https://github.com/raimon49/pip-licenses/issues/128
`pip-licenses<4` is broken in Python 3.11. Update the bound to support py311
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26019: Update pip-licenses in Dockerfile to support Python 3.11
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26019:
URL: https://github.com/apache/beam/pull/26019#issuecomment-1487566960
## [Codecov](https://codecov.io/gh/apache/beam/pull/26019?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#26019](https://codecov.io/gh/apache/beam/pull/26019?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6f476cd) into [master](https://codecov.io/gh/apache/beam/commit/469101dd378368d1a9cbb3418b81e28506d72bdf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (469101d) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #26019 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 779 779
Lines 102635 102635
=======================================
+ Hits 73308 73312 +4
+ Misses 27867 27863 -4
Partials 1460 1460
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `79.96% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 4 files with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/26019/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on a diff in pull request #26019: Update pip-licenses in Dockerfile to support Python 3.11
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on code in PR #26019:
URL: https://github.com/apache/beam/pull/26019#discussion_r1151113884
##########
sdks/python/container/Dockerfile:
##########
@@ -101,7 +101,7 @@ RUN rm /opt/apache/beam/third_party_licenses/golang/LICENSE
COPY target/license_scripts /tmp/license_scripts/
RUN if [ "$pull_licenses" = "true" ] ; then \
- pip install 'pip-licenses<4.0.0' pyyaml tenacity && \
+ pip install 'pip-licenses<=4.1.0' pyyaml tenacity && \
Review Comment:
Ah. I started with `<5` but for some reason I changed it to `<=`. committed the updated code now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a diff in pull request #26019: Update pip-licenses in Dockerfile to support Python 3.11
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #26019:
URL: https://github.com/apache/beam/pull/26019#discussion_r1151112468
##########
sdks/python/container/Dockerfile:
##########
@@ -101,7 +101,7 @@ RUN rm /opt/apache/beam/third_party_licenses/golang/LICENSE
COPY target/license_scripts /tmp/license_scripts/
RUN if [ "$pull_licenses" = "true" ] ; then \
- pip install 'pip-licenses<4.0.0' pyyaml tenacity && \
+ pip install 'pip-licenses<=4.1.0' pyyaml tenacity && \
Review Comment:
using <= in version constraints is almost always wrong, as that excludes newer minor version, and is largely equivalent to ==4.1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a diff in pull request #26019: Update pip-licenses in Dockerfile to support Python 3.11
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #26019:
URL: https://github.com/apache/beam/pull/26019#discussion_r1151112678
##########
sdks/python/container/Dockerfile:
##########
@@ -101,7 +101,7 @@ RUN rm /opt/apache/beam/third_party_licenses/golang/LICENSE
COPY target/license_scripts /tmp/license_scripts/
RUN if [ "$pull_licenses" = "true" ] ; then \
- pip install 'pip-licenses<4.0.0' pyyaml tenacity && \
+ pip install 'pip-licenses<=4.1.0' pyyaml tenacity && \
Review Comment:
```suggestion
pip install 'pip-licenses<5' pyyaml tenacity && \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #26019: Update pip-licenses in Dockerfile to support Python 3.11
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn merged PR #26019:
URL: https://github.com/apache/beam/pull/26019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26019: Update pip-licenses in Dockerfile to support Python 3.11
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26019:
URL: https://github.com/apache/beam/pull/26019#issuecomment-1487496654
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #26019: Update pip-licenses in Dockerfile to support Python 3.11
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #26019:
URL: https://github.com/apache/beam/pull/26019#issuecomment-1487495400
R: @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org