You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2011/05/17 19:10:49 UTC

[jira] [Commented] (THRIFT-1170) Thrift Generated Code and Java 5

    [ https://issues.apache.org/jira/browse/THRIFT-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034889#comment-13034889 ] 

Bryan Duxbury commented on THRIFT-1170:
---------------------------------------

Is this patch based on the 0.6.1 branch? I'd prefer not to make more modifications to that branch and instead work on trunk. Would you be willing to rebase your patch to trunk?

> Thrift Generated Code and Java 5
> --------------------------------
>
>                 Key: THRIFT-1170
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1170
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler
>    Affects Versions: 0.6.1
>            Reporter: Greg Moulliet
>         Attachments: java5.patch
>
>
> The Thrift Java compiler creates code that is not compliant with Java 5.
> One issue is the @Override annotation on the clear() method.
> The other issue is creating a IOException with a TException as a parameter in writeObject and readObject.
> The attached patch creates a new option for the compiler, java5, which outputs java 5 compliant code.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira