You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by pr...@apache.org on 2014/02/13 23:17:19 UTC

svn commit: r1568067 - in /hive/trunk/jdbc/src/java/org/apache/hive/jdbc: HiveDatabaseMetaData.java Utils.java

Author: prasadm
Date: Thu Feb 13 22:17:19 2014
New Revision: 1568067

URL: http://svn.apache.org/r1568067
Log:
HIVE-6372: getDatabaseMajor/Minor version returns wrong values (Szehon Ho via Prasad Mujumdar)

Modified:
    hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
    hive/trunk/jdbc/src/java/org/apache/hive/jdbc/Utils.java

Modified: hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
URL: http://svn.apache.org/viewvc/hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java?rev=1568067&r1=1568066&r2=1568067&view=diff
==============================================================================
--- hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java (original)
+++ hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java Thu Feb 13 22:17:19 2014
@@ -258,11 +258,11 @@ public class HiveDatabaseMetaData implem
   }
 
   public int getDatabaseMajorVersion() throws SQLException {
-    return Utils.getVersionPart(getDatabaseProductVersion(), 1);
+    return Utils.getVersionPart(getDatabaseProductVersion(), 0);
   }
 
   public int getDatabaseMinorVersion() throws SQLException {
-    return Utils.getVersionPart(getDatabaseProductVersion(), 2);
+    return Utils.getVersionPart(getDatabaseProductVersion(), 1);
   }
 
   public String getDatabaseProductName() throws SQLException {

Modified: hive/trunk/jdbc/src/java/org/apache/hive/jdbc/Utils.java
URL: http://svn.apache.org/viewvc/hive/trunk/jdbc/src/java/org/apache/hive/jdbc/Utils.java?rev=1568067&r1=1568066&r2=1568067&view=diff
==============================================================================
--- hive/trunk/jdbc/src/java/org/apache/hive/jdbc/Utils.java (original)
+++ hive/trunk/jdbc/src/java/org/apache/hive/jdbc/Utils.java Thu Feb 13 22:17:19 2014
@@ -234,8 +234,8 @@ public class Utils {
    * @param fullVersion
    *          version string.
    * @param tokenPosition
-   *          position of version string to get starting at 1. eg, for a X.x.xxx
-   *          string, 1 will return the major version, 2 will return minor
+   *          position of version string to get starting at 0. eg, for a X.x.xxx
+   *          string, 0 will return the major version, 1 will return minor
    *          version.
    * @return version part, or -1 if version string was malformed.
    */