[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1232: [CELEBORN-295] Pipeline sort pusher by double-buffering

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #1232:
URL: https://github.com/apache/incubator-celeborn/pull/1232#discussion_r1115558287


##########
build/make-distribution.sh:
##########
@@ -127,7 +127,7 @@ function build_service {
   # Store the command as an array because $MVN variable might have spaces in it.
   # Normal quoting tricks don't work.
   # See: http://mywiki.wooledge.org/BashFAQ/050
-  BUILD_COMMAND=("$MVN" clean package -DskipTests $@)

Review Comment:
   +1, please reserve clean, dirty cache may cause fatal issues



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org