You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/03 09:41:26 UTC
[GitHub] [incubator-pekko] danischroeter commented on a diff in pull request #4: !str Logging error instead of failing the `keepAlive` operator.
danischroeter commented on code in PR #4:
URL: https://github.com/apache/incubator-pekko/pull/4#discussion_r1012678036
##########
akka-stream/src/main/scala/akka/stream/impl/Timers.scala:
##########
@@ -275,11 +275,15 @@ import akka.stream.stage._
val now = System.nanoTime()
// Timer is reliably cancelled if a regular element arrives first. Scheduler rather schedules too late
// than too early so the deadline must have passed at this time.
- assert(
- now - nextDeadline >= 0,
Review Comment:
> One issue might be that people use weird base images in their docker images (like alpine which has several edge cases people might not expect).
In this case it would help the user to get a WARN log. It should not be DEBUG since it's not expected to happen. And even for the people that stumbled upon its still rare.
##########
akka-stream/src/main/scala/akka/stream/impl/Timers.scala:
##########
@@ -275,11 +275,15 @@ import akka.stream.stage._
val now = System.nanoTime()
// Timer is reliably cancelled if a regular element arrives first. Scheduler rather schedules too late
// than too early so the deadline must have passed at this time.
- assert(
- now - nextDeadline >= 0,
Review Comment:
> One issue might be that people use weird base images in their docker images (like alpine which has several edge cases people might not expect).
In this case it would help the user to get a WARN log. It should not be DEBUG since it's not expected to happen. And even for the people that stumbled upon its still rare.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org
For additional commands, e-mail: commits-help@pekko.apache.org