You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/23 15:31:50 UTC
[GitHub] [solr] risdenk opened a new pull request #696: Upgrade to errorprone 2.11.0
risdenk opened a new pull request #696:
URL: https://github.com/apache/solr/pull/696
https://issues.apache.org/jira/browse/SOLR-XXXXX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #696: SOLR-16050: Upgrade to errorprone 2.11.0
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #696:
URL: https://github.com/apache/solr/pull/696#issuecomment-1051081755
well @madrob I should say no new checks that were worth anything that caused changes in the Solr codebase:
https://github.com/google/error-prone/releases/tag/v2.11.0
There are definitely new checks, but didn't require any changes to Solr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #696: SOLR-16050: Upgrade to errorprone 2.11.0
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #696:
URL: https://github.com/apache/solr/pull/696#issuecomment-1049110192
> So did the new version of ErrorProne give us any useful checks?
Not that I could tell sadly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #696: SOLR-16050: Upgrade to errorprone 2.11.0
Posted by GitBox <gi...@apache.org>.
risdenk merged pull request #696:
URL: https://github.com/apache/solr/pull/696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #696: SOLR-16050: Upgrade to errorprone 2.11.0
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #696:
URL: https://github.com/apache/solr/pull/696#discussion_r813139363
##########
File path: gradle/validation/error-prone.gradle
##########
@@ -64,6 +64,7 @@ allprojects { prj ->
'-Xep:ComparableType:OFF', // SolrTestCaseJ4.Doc and Fld are messy
'-Xep:AlmostJavadoc:OFF',
+ '-Xep:AlreadyChecked:OFF',
Review comment:
This check makes logic way more confusing in the few cases it came up.
##########
File path: gradle/validation/error-prone.gradle
##########
@@ -104,9 +105,9 @@ allprojects { prj ->
'-Xep:MissingSummary:OFF',
'-Xep:MixedMutabilityReturnType:OFF',
'-Xep:ModifiedButNotUsed:OFF',
- '-Xep:MutableConstantField:OFF',
'-Xep:MutablePublicArray:OFF',
'-Xep:NarrowingCompoundAssignment:OFF',
+ '-Xep:NegativeCharLiteral:OFF',
Review comment:
Solr uses negative chars in a few places correctly and so this check wasn't worth it.
##########
File path: gradle/validation/error-prone.gradle
##########
@@ -104,9 +105,9 @@ allprojects { prj ->
'-Xep:MissingSummary:OFF',
'-Xep:MixedMutabilityReturnType:OFF',
'-Xep:ModifiedButNotUsed:OFF',
- '-Xep:MutableConstantField:OFF',
Review comment:
No longer a valid check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #696: SOLR-16050: Upgrade to errorprone 2.11.0
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #696:
URL: https://github.com/apache/solr/pull/696#issuecomment-1049105991
So did the new version of ErrorProne give us any _useful_ checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org