[GitHub] [activemq-artemis] clebertsuconic commented on issue #2817: Network check custom ping priority

[GitBox <gi...@apache.org>]

clebertsuconic commented on issue #2817: Network check custom ping priority
URL: https://github.com/apache/activemq-artemis/pull/2817#issuecomment-526388296
 
 
   You made a mess on your PR here.. you don't need to keep every single commit.. you can just squash all your changes and keep one change only.  but I was able to squash them and keep your ownership.
   
   I'm adding a test.. and I'm merging after I cleaned it up. but in the future (that's for any git based project.. not just artemis), you should cleanup your PR. you could:
   
   ```
   # 5 here is number of commits you have
   # use the list to squash them, google for git rebase -i, you will go through an editor such as vi
   git rebase -i HEAD~5 
   git push origin <your_branch_name> -f
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services