You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2021/09/23 07:41:28 UTC

[GitHub] [incubator-heron] nwangtw commented on a change in pull request #3710: [HERON-3707] ConfigMap Pod Template Support

nwangtw commented on a change in pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710#discussion_r714544245



##########
File path: heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/V1Controller.java
##########
@@ -386,7 +386,7 @@ private V1StatefulSet createStatefulSet(Resource containerResource, int numberOf
     statefulSetSpec.selector(selector);
 
     // create a pod template
-    final V1PodTemplateSpec podTemplateSpec = loadPodFromTemplate();
+    final V1PodTemplateSpec podTemplateSpec = new V1PodTemplateSpec();

Review comment:
       Hmm. Maybe it is because `loadPodFromTemplate()` throws an exception?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org