You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/06/06 13:24:55 UTC
Review Request: CLOUDSTACK-2288: NPE while creating volume from snapshot
when the primary storage is in maintenance state.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11670/
-----------------------------------------------------------
Review request for cloudstack and Devdeep Singh.
Description
-------
CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
This addresses bug CLOUDSTACK-2288.
Diffs
-----
server/src/com/cloud/storage/VolumeManagerImpl.java 43f3681
Diff: https://reviews.apache.org/r/11670/diff/
Testing
-------
Tests:
1. In CS setup, put all primary storage in maintenance mode.
2. Create a volume from snapshot.
Verified the fix locally.
Thanks,
Sanjay Tripathi
Re: Review Request 11670: CLOUDSTACK-2288: NPE while creating volume from
snapshot when the primary storage is in maintenance state.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11670/#review22595
-----------------------------------------------------------
Commit ffd5f1a777ac9af5b65b1fcd357684d7dafcce87 in branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ffd5f1a ]
CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On July 1, 2013, 9:18 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11670/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 9:18 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Devdeep Singh, and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-2288
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/VolumeManagerImpl.java a293da5
>
> Diff: https://reviews.apache.org/r/11670/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. In CS setup, put all primary storage in maintenance mode.
> 2. Create a volume from snapshot.
>
> Verified the fix locally.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 11670: CLOUDSTACK-2288: NPE while creating volume from
snapshot when the primary storage is in maintenance state.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11670/#review22625
-----------------------------------------------------------
Commit ffd5f1a777ac9af5b65b1fcd357684d7dafcce87 in branch refs/heads/vmsync from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ffd5f1a ]
CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On July 1, 2013, 9:18 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11670/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 9:18 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Devdeep Singh, and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-2288
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/VolumeManagerImpl.java a293da5
>
> Diff: https://reviews.apache.org/r/11670/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. In CS setup, put all primary storage in maintenance mode.
> 2. Create a volume from snapshot.
>
> Verified the fix locally.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 11670: CLOUDSTACK-2288: NPE while creating volume from
snapshot when the primary storage is in maintenance state.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11670/#review22953
-----------------------------------------------------------
Commit 527080e8effe675e7875fff6a0a69de606e3e3eb in branch refs/heads/master-6-17-stable from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=527080e ]
CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
- ASF Subversion and Git Services
On July 1, 2013, 9:18 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11670/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 9:18 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Devdeep Singh, and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-2288
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/VolumeManagerImpl.java a293da5
>
> Diff: https://reviews.apache.org/r/11670/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. In CS setup, put all primary storage in maintenance mode.
> 2. Create a volume from snapshot.
>
> Verified the fix locally.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 11670: CLOUDSTACK-2288: NPE while creating volume from
snapshot when the primary storage is in maintenance state.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11670/#review22597
-----------------------------------------------------------
Commit 58e69704ea9876b3c5195d085f9a7056b7f65298 in branch refs/heads/4.2 from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=58e6970 ]
CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit ffd5f1a777ac9af5b65b1fcd357684d7dafcce87)
- ASF Subversion and Git Services
On July 1, 2013, 9:18 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11670/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 9:18 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Devdeep Singh, and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-2288
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/VolumeManagerImpl.java a293da5
>
> Diff: https://reviews.apache.org/r/11670/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. In CS setup, put all primary storage in maintenance mode.
> 2. Create a volume from snapshot.
>
> Verified the fix locally.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 11670: CLOUDSTACK-2288: NPE while creating volume from
snapshot when the primary storage is in maintenance state.
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11670/
-----------------------------------------------------------
(Updated July 1, 2013, 9:18 a.m.)
Review request for cloudstack, Abhinandan Prateek, Devdeep Singh, and Prasanna Santhanam.
Bugs: CLOUDSTACK-2288
Repository: cloudstack-git
Description
-------
CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
Diffs
-----
server/src/com/cloud/storage/VolumeManagerImpl.java a293da5
Diff: https://reviews.apache.org/r/11670/diff/
Testing
-------
Tests:
1. In CS setup, put all primary storage in maintenance mode.
2. Create a volume from snapshot.
Verified the fix locally.
Thanks,
Sanjay Tripathi
Re: Review Request 11670: CLOUDSTACK-2288: NPE while creating volume from
snapshot when the primary storage is in maintenance state.
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11670/
-----------------------------------------------------------
(Updated July 1, 2013, 9:18 a.m.)
Review request for cloudstack and Devdeep Singh.
Changes
-------
Updated patch.
Bugs: CLOUDSTACK-2288
Repository: cloudstack-git
Description
-------
CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
Diffs (updated)
-----
server/src/com/cloud/storage/VolumeManagerImpl.java a293da5
Diff: https://reviews.apache.org/r/11670/diff/
Testing
-------
Tests:
1. In CS setup, put all primary storage in maintenance mode.
2. Create a volume from snapshot.
Verified the fix locally.
Thanks,
Sanjay Tripathi
Re: Review Request 11670: CLOUDSTACK-2288: NPE while creating volume from
snapshot when the primary storage is in maintenance state.
Posted by Sanjay Tripathi <sa...@citrix.com>.
> On June 30, 2013, 6:50 a.m., Prasanna Santhanam wrote:
> > Applying: CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
> > error: patch failed: server/src/com/cloud/storage/VolumeManagerImpl.java:523
> > error: server/src/com/cloud/storage/VolumeManagerImpl.java: patch does not apply
> > Patch failed at 0001 CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
> > When you have resolved this problem run "git am --resolved".
> > If you would prefer to skip this patch, instead run "git am --skip".
> > To restore the original branch and stop patching run "git am --abort".
> >
> > Fails to apply because of storage related changes. Can you retest if this is still an issue and submit the patch?
> >
> > Thanks
The issue is still there in master so recreating the patch based on latest master code.
- Sanjay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11670/#review22579
-----------------------------------------------------------
On June 6, 2013, 11:24 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11670/
> -----------------------------------------------------------
>
> (Updated June 6, 2013, 11:24 a.m.)
>
>
> Review request for cloudstack and Devdeep Singh.
>
>
> Bugs: CLOUDSTACK-2288
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/VolumeManagerImpl.java 43f3681
>
> Diff: https://reviews.apache.org/r/11670/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. In CS setup, put all primary storage in maintenance mode.
> 2. Create a volume from snapshot.
>
> Verified the fix locally.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 11670: CLOUDSTACK-2288: NPE while creating volume from
snapshot when the primary storage is in maintenance state.
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11670/#review22579
-----------------------------------------------------------
Applying: CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
error: patch failed: server/src/com/cloud/storage/VolumeManagerImpl.java:523
error: server/src/com/cloud/storage/VolumeManagerImpl.java: patch does not apply
Patch failed at 0001 CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Fails to apply because of storage related changes. Can you retest if this is still an issue and submit the patch?
Thanks
- Prasanna Santhanam
On June 6, 2013, 11:24 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11670/
> -----------------------------------------------------------
>
> (Updated June 6, 2013, 11:24 a.m.)
>
>
> Review request for cloudstack and Devdeep Singh.
>
>
> Bugs: CLOUDSTACK-2288
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/VolumeManagerImpl.java 43f3681
>
> Diff: https://reviews.apache.org/r/11670/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. In CS setup, put all primary storage in maintenance mode.
> 2. Create a volume from snapshot.
>
> Verified the fix locally.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>